feat(product_enablement): Add support for NGWAF. #550
Merged
+311
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpfleming
force-pushed
the
cdtool-913
branch
from
0d263c4
to
febabd2
Compare
There was a problem hiding this comment.
This looks good to me but according to https://www.fastly.com/documentation/reference/api/products/enablement/ there are two more endpoints. Would it not make sense to add those to the test suite?
|
Yes it would, but that will need to be done as a separate task I believe. I'll enter an issue for that. |
|
I've created (internal) issue CDTOOL-932 for adding the product configuration endpoints. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.