Changes needed to follow the syntax of PHP 8.4

fastly · Dec 11, 2024 · 1d6f2d1 · 1d6f2d1
1 parent e8dfde5
commit 1d6f2d1
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/Model/Config.php b/Model/Config.php
@@ -587,9 +587,9 @@ public function __construct(
         StateInterface $cacheState,
         Dir\Reader $reader,
         VclGeneratorFactory $vclGeneratorFactory,
-        Json $serializer = null,
-        StoreManagerInterface $storeManager = null,
-        GeolocationRedirectMatcher $geolocationRedirectMatcher = null
+        ?Json $serializer = null,
+        ?StoreManagerInterface $storeManager = null,
+        ?GeolocationRedirectMatcher $geolocationRedirectMatcher = null
     ) {
         $this->serializer = $serializer ?: ObjectManager::getInstance()->get(Json::class);
         $this->geolocationRedirectMatcher = $geolocationRedirectMatcher ?:

diff --git a/Model/Config/Backend/Geoipcountry.php b/Model/Config/Backend/Geoipcountry.php
@@ -60,10 +60,10 @@ public function __construct(
         ScopeConfigInterface $config,
         TypeListInterface $cacheTypeList,
         SerializerInterface $serializerInterface,
-        AbstractResource $resource = null,
-        AbstractDb $resourceCollection = null,
+        ?AbstractResource $resource = null,
+        ?AbstractDb $resourceCollection = null,
         array $data = [],
-        Json $serializer = null
+        ?Json $serializer = null
     ) {
         $this->serializerInterface = $serializerInterface;
         parent::__construct(

diff --git a/Model/Notification.php b/Model/Notification.php
@@ -98,8 +98,8 @@ public function __construct(
         ClientFactory        $clientFactory,
         RequestFactory       $requestFactory,
         InboxFactory         $inboxFactory,
-        AbstractResource     $resource = null,
-        AbstractDb           $resourceCollection = null,
+        ?AbstractResource    $resource = null,
+        ?AbstractDb          $resourceCollection = null,
         array                $data = []
     ) {
         $this->scopeConfig = $scopeConfig;

diff --git a/Model/Statistic.php b/Model/Statistic.php
@@ -181,8 +181,8 @@ public function __construct(
         Data $helper,
         ProductMetadataInterface $productMetadata,
         Http $request,
-        \Magento\Framework\Model\ResourceModel\AbstractResource $resource = null,
-        AbstractDb $resourceCollection = null,
+        ?\Magento\Framework\Model\ResourceModel\AbstractResource $resource = null,
+        ?AbstractDb $resourceCollection = null,
         array $data = []
     ) {
         $this->config = $config;