Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document import_from_gem #1157

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lacostej
Copy link
Collaborator

This is related to fastlane/fastlane#20294

@rogerluan
Copy link
Member

@lacostej could you rebase your branch to trigger Netlify preview again? 🙏

@lacostej
Copy link
Collaborator Author

@lacostej could you rebase your branch to trigger Netlify preview again? 🙏

done

Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicks, otherwise LGTM 😊

docs/advanced/Fastfile.md Outdated Show resolved Hide resolved
Comment on lines +125 to +126
import_from_gem(gem_name: 'my_gem',
paths: ['fastlane/Fastfile', 'fastlane/Fastfile_*'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh weird indentation? 👀 Can we do e.g.:

Suggested change
import_from_gem(gem_name: 'my_gem',
paths: ['fastlane/Fastfile', 'fastlane/Fastfile_*'])
import_from_gem(gem_name: 'my_gem', paths: ['fastlane/Fastfile', 'fastlane/Fastfile_*'])

or

Suggested change
import_from_gem(gem_name: 'my_gem',
paths: ['fastlane/Fastfile', 'fastlane/Fastfile_*'])
import_from_gem(
gem_name: 'my_gem',
paths: ['fastlane/Fastfile', 'fastlane/Fastfile_*'],
)

or

Suggested change
import_from_gem(gem_name: 'my_gem',
paths: ['fastlane/Fastfile', 'fastlane/Fastfile_*'])
import_from_gem(gem_name: 'my_gem', paths: [
'fastlane/Fastfile',
'fastlane/Fastfile_*',
])

? 🙈

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intended indentation might've been this:

Suggested change
import_from_gem(gem_name: 'my_gem',
paths: ['fastlane/Fastfile', 'fastlane/Fastfile_*'])
import_from_gem(gem_name: 'my_gem',
paths: ['fastlane/Fastfile', 'fastlane/Fastfile_*'])

But I'm not a fan, hence why I suggested the 3 others above 😂 I'd pick the first one because I don't care much about horizontal line length, but the others are fine too

docs/advanced/Fastfile.md Outdated Show resolved Hide resolved
docs/advanced/Fastfile.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants