Skip to content
This repository was archived by the owner on Nov 19, 2018. It is now read-only.

Commit

Permalink
Merge pull request #209 from lmirosevic/escaping-fix
Browse files Browse the repository at this point in the history
Shellescape fix for 1.2.1 introduced in #198
  • Loading branch information
KrauseFx committed Nov 11, 2015
2 parents b57fe34 + 9fa1f42 commit 96871e3
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions lib/sigh/resign.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ def run(options, args)
# get the command line inputs and parse those into the vars we need...
ipa, signing_identity, provisioning_profiles = get_inputs(options, args)

# ... then invoke out programmatic interface with these vars
# ... then invoke our programmatic interface with these vars
resign(ipa, signing_identity, provisioning_profiles)
end

Expand All @@ -26,13 +26,13 @@ def resign(ipa, signing_identity, provisioning_profiles)
# validate that we have valid values for all these params, we don't need to check signing_identity because `find_signing_identity` will only ever return a valid value
validate_params(resign_path, ipa, provisioning_profiles)

provisioning_options = provisioning_profiles.map { |fst, snd| "-p #{[fst, snd].compact.join('=')}" }.join(' ')
provisioning_options = provisioning_profiles.map { |fst, snd| "-p #{[fst, snd].compact.map(&:shellescape).join('=')}" }.join(' ')

command = [
resign_path.shellescape,
ipa.shellescape,
signing_identity.shellescape,
provisioning_options.shellescape,
provisioning_options, # we are aleady shellescaping this above, when we create the provisioning_options from the provisioning_profiles
ipa.shellescape
].join(' ')

Expand Down

0 comments on commit 96871e3

Please sign in to comment.