Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: deflake tests #113

Merged
merged 9 commits into from
Dec 24, 2023
Merged

test: deflake tests #113

merged 9 commits into from
Dec 24, 2023

Conversation

Uzlopak
Copy link
Collaborator

@Uzlopak Uzlopak commented Dec 23, 2023 •
edited by Fdawgs
Loading

Closes #110
I guess we should have awaited some of the .register() calls and make it more robust.

Checklist

@Uzlopak
Copy link
Collaborator Author

Uzlopak commented Dec 24, 2023

I ran the CI twice now and no tests failed.

@Uzlopak Uzlopak mentioned this pull request Dec 24, 2023
Merged
4 tasks
@Uzlopak Uzlopak changed the title fix(test): deflake csp test fix(test): deflake tests Dec 24, 2023
@Fdawgs Fdawgs changed the title fix(test): deflake tests test: deflake tests Dec 24, 2023
mcollina
mcollina reviewed Dec 24, 2023
View reviewed changes
test/integration.test.js Outdated Show resolved Hide resolved
mcollina
mcollina requested changes Dec 24, 2023
View reviewed changes
test/route.test.js Outdated Show resolved Hide resolved
test/route.test.js Outdated Show resolved Hide resolved
@Uzlopak
Copy link
Collaborator Author

Uzlopak commented Dec 24, 2023

@mcollina
PTAL

;)

mcollina
mcollina reviewed Dec 24, 2023
View reviewed changes
index.js Outdated Show resolved Hide resolved
@mcollina
Copy link
Member

disabling code coverage would make the test pass, there is a bug in node

@Uzlopak
Copy link
Collaborator Author

Uzlopak commented Dec 24, 2023

@mcollina

Well, i dont know anymore. I tried to improve the code at best to avoid any race conditions or whatever. I quite dont get why it fails. But if you are ok, i would like to merge.

mcollina
mcollina approved these changes Dec 24, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 3cf8d5d into master Dec 24, 2023
31 checks passed
@Uzlopak Uzlopak deleted the deflake-test branch December 24, 2023 18:09
@DavidTanner DavidTanner mentioned this pull request Dec 26, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fdawgs Fdawgs Fdawgs approved these changes

@mcollina mcollina mcollina approved these changes

@jsumners jsumners Awaiting requested review from jsumners

@kibertoad kibertoad Awaiting requested review from kibertoad

@Eomm Eomm Awaiting requested review from Eomm

@gurgunday gurgunday Awaiting requested review from gurgunday

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests are randomly failing
3 participants
@Uzlopak @mcollina @Fdawgs