fix: refactor requestContextPlugin.spec.js to use response headers #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of JSON body
Closed
|
#177 is a possible alternative approach. Not sure what is the best one :) |
Eomm
reviewed
Dec 18, 2023
test/requestContextPlugin.spec.js
Outdated
| reply.status(204).send({ | ||
| storedValue, | ||
| }) | ||
| reply.status(204).header('storedvalue', storedValue).send() |
There was a problem hiding this comment.
The solution LGTM
I preferred the #177 because the 204 status code was not necessary to make the module work, so it was adding confusion and it is better to remove it instead.
If you would like to update this PR adding an clear test such the plugin must keep the context across 20x requests it would be best!
There was a problem hiding this comment.
Hey, so something like the plugin must keep the context across 204 requests => then use the headers in a separate case? @Eomm
There was a problem hiding this comment.
i have added a new case, does it make sense? what changes would you recommend 🤔 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #175
I replaced the json body with value in headers. I found this to be the best approach. if anyone has any better solutions, happy to implement that as well.
Checklist
npm run testandnpm run benchmark(can't find script benchmark)and the Code of conduct