-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify pipeline patch #30
base: master
Are you sure you want to change the base?
Conversation
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
nbs/01_augment.ipynb
Outdated
@@ -49,6 +49,9 @@ | |||
"outputs": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The verify_pipeline function defined here should be instead on the Pipelines section, that is a couple of cells below. Also, it would be very helpful to include some examples, and you can add tests that it works using test_warns
function from fastcore.
Reply via ReviewNB
The tests are breaking because of a problem while exporting the code from the notebooks. Please follow the instructions to fix it:
pip install nbdev --upgrade
nbdev_clean_nbs
nbdev_build_lib
nbdev_build_docs
The instructions to contribute that are present on the repository at the moment are lacking, I will update them. |
Surely we ca add those the into the pre-commit hook? |
The verify_pipeline method covers the known edge-cases for the transforms pipeline. The design is to introduce an extensible framework to check future cases.