✨ feat: json and bytes field support in options #985
Conversation
Signed-off-by: Muhammed Hussein Karimi <[email protected]>
Signed-off-by: Muhammed Hussein Karimi <[email protected]>
Signed-off-by: Muhammed Hussein Karimi <[email protected]>
|
📝 Docs preview for commit 137e1bc at: https://5f9b3d47.typertiangolo.pages.dev |
Signed-off-by: Muhammed Hussein Karimi <[email protected]>
|
📝 Docs preview for commit 0f5a1b3 at: https://ae7752e5.typertiangolo.pages.dev |
|
📝 Docs preview for commit 432a48c at: https://b02f882e.typertiangolo.pages.dev |
Signed-off-by: Muhammed Hussein Karimi <[email protected]>
mhkarimi1383
changed the title
|
📝 Docs preview for commit 31e7623 at: https://6e9177ee.typertiangolo.pages.dev Modified Pages |
Signed-off-by: Muhammed Hussein Karimi <[email protected]>
|
📝 Docs preview for commit f83e798 at: https://4dcf841b.typertiangolo.pages.dev Modified Pages |
|
@svlandeg it's ok to ignore coverage on newly created class? |
|
No, in general we really need all the code in the main modules to be fully tested 🙏 |
|
📝 Docs preview for commit fdb7bb4 at: https://4a6543f8.typertiangolo.pages.dev Modified Pages |
|
📝 Docs preview for commit 114b761 at: https://10931053.typertiangolo.pages.dev Modified Pages |
|
I have added tests for newly created class coverage is 100% again :) |
|
If changes are Ok so far I can work on Pydantic support, Or move Pydantic support in another PR? |
|
HI @mhkarimi1383! We haven't yet been able to review this PR in detail. When we do, we'll update here. No need to ping individual maintainers in the meantime 😉 In terms of adding more functionality, it's always best to open separate PRs for distinct functionality. It makes the review process much easier if one PR deals with one "atomic" change. Do have a look at existing PRs - if I recall correctly there's already a few PRs open with proposals for Pydantic support. |
|
Thanks again for this PR @mhkarimi1383! I'm going to start reviewing it in detail and will push some changes directly to your branch as I'm working on this. I'll put this PR in draft while I do so. |
|
📝 Docs preview for commit 4b75b07 at: https://b35af1bf.typertiangolo.pages.dev Modified Pages |
|
Related issue: #130 |
|
📝 Docs preview for commit 71ca8e3 at: https://c07678b2.typertiangolo.pages.dev Modified Pages |
|
📝 Docs preview for commit 240d614 at: https://2bfcd0bd.typertiangolo.pages.dev Modified Pages |
|
📝 Docs preview for commit 966206d at: https://8a6ac4e7.typertiangolo.pages.dev Modified Pages |
|
📝 Docs preview for commit 7caf522 at: https://c8c1eb20.typertiangolo.pages.dev Modified Pages |
|
We are calling it dict, but cli arg should be provided as JSON since we are using json to parse input |
Yea, I'm a little on the fence as to what to call it best. In the tutorial it's about parameter types and there it is typed as a |
|
Yeah, but I think in the repr we can call it JSON, So CLi users that they want to use our application should know that the input has to be JSON |
Hi
Some times there is a need to have results as
bytes(that is builtin supported byclick.STRING)and also there is a need of decoding entire value as an json object (useful when some params are too dynamic or getting that option in a prompt). I wanted to also add pydantic support (for both single option as json and all of the options in a single model) there and also use orjson (by checking if that's installed as an optional dependency), If that's Ok.