-
-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔥 Drop support for Python 3.7 #830
base: master
Are you sure you want to change the base?
Conversation
📝 Docs preview for commit 18178cf at: https://63aa4de4.typertiangolo.pages.dev |
18178cf
to
314f504
Compare
📝 Docs preview for commit 2e8fcdd at: https://27073bc3.typertiangolo.pages.dev |
2e8fcdd
to
caf601e
Compare
📝 Docs preview for commit caf601e at: https://8c1c8efc.typertiangolo.pages.dev |
CI tests pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the very thorough PR!
I'll have to ask @tiangolo what the term is he wants to drop Python 3.7 by.
Note - I'm also maintaining spaCy and there we just bumped the Typer pin to allow any v0.x. If Typer drops Python 3.7 which spaCy v3 still supports, we'll have to again restrict the upper bound for Typer there. And I can imagine spaCy not being the only repo that would run into this.
I think we'll want to drop 3.7 at some point, it's just a question of when :-)
📝 Docs preview for commit 36c4439 at: https://0e84aba4.typertiangolo.pages.dev |
@svlandeg, thanks for reviewing the PR and for sharing your thoughts. 👍 I understand the concern about avoiding breaking dependent libraries. Besides, I rechecked the |
Thanks @kinuax! I want to keep support for Python 3.7 for a while. It's currently not being a problem (yet) so I prefer to delay this a bit. I would also want to have some features and fixes in before dropping support, so that people stuck in 3.7 can benefit from them too. |
📝 Docs preview for commit 5facc11 at: https://b83f7230.typertiangolo.pages.dev |
@tiangolo, all right, I understand, thanks for clarifying. |
CPython and click already dropped support for Python 3.7. I would propose to proceed accordingly here in order to benefit from:
3.7 occurrences are updated.
Literal
related branching is cleaned._typing
is updated and simplified. All local tests pass on 3.8-3.12 and Linux.Context: #828