Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Support common pydantic types #723
base: master
Are you sure you want to change the base?
✨ Support common pydantic types #723
Changes from all commits
25a5c37
57f0cb7
6039b4f
c38fefc
e0ad01b
0ff28ba
6dccd26
10e7986
893d86e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make sure to skip these tests when
pydantic
and/oremail-validator
aren't installed (instead of running them and getting import errors and failing tests)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I made necessary changes to have everything installed for tests, I don't get the point of skipping the tests, except if we want to ensure that typer still works without pydantic, but running both flavours would be cumbersome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally think it's a valid use-case for someone to be developing on Typer and to be running the test suite locally, without wanting to install
pydantic
for Pydantic-related tests if they don't care about that...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my experience, it's better to not skip tests on such conditions because it's "easy" to silently break
pydantic
support because someone has removed the dependency inrequirements-test.txt
and CI didn't complain.If a developer tests in local and doesn't have
pydantic
installed, I wouldn't expect them to run the full suite including tests onpydantic
support (though, it's a best practice to run them, with the appropriate dependencies that the repository defines)