Tackle compatibility issues with Click 8.2 #1145
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Click 8.2 now expects the context to be passed to the make_metavar method. To enable Typer to be used both with new and old versions of Click, this passes the parameter conditionally. For the make_metavar override to stay compatible, pass the parameter through via catchall for
positional arguments.
|
I am not sure how much time I'll have to look into those additional failing tests. Anybody feel free to adopt (parts of) this for a proper fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this as a heads up regarding a compatibility problem with Click 8.2.0. Click changes the signature of the
make_metavarandget_metavarfunctions.This PR provides compatibility with both older and newer versions of Click by verifying the function signature.
Click also changed behaviour in various ways that are breaking tests even though Typer itself works as expected. The PR so far tackles the trivial cases. However, there are still tests remaining that will need a closer look to ensure compatibility.