-
-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Ensure that Optional[list]
values work correctly with callbacks
#1018
base: master
Are you sure you want to change the base?
Conversation
📝 Docs preview for commit 5c9ba8f at: https://d5834c3f.typertiangolo.pages.dev |
📝 Docs preview for commit ade4517 at: https://3a35550f.typertiangolo.pages.dev |
@tiangolo, Hi! Please check this review. It blocks our application from upgrading to |
cc: @svlandeg |
Hi @solesensei, thanks for the PR! We've got this on our internal queue and will let you know once we've been able to review it 🙏 |
Optional[list]
values work correctly with callbacks
@svlandeg I'm sorry, but could you please take a look at this PR? It's a simple one-line fix that shouldn't take much time. |
@solesensei: like I said, we have this on our queue and will look at it soon. Please refrain from pinging maintainers directly, as this makes our Github mentions very difficult to use and we don't just give priority to whoever pings the most 😉 |
📝 Docs preview for commit 07350b5 at: https://543f0da8.typertiangolo.pages.dev |
This pull request refactors the
generate_list_convertor
function to handle the case when thevalue
parameter isNone
.Fixes: #762