Playlist description #5561
Open
Playlist description #5561
+73
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto database. TODO: Display the playlist description
…ist-Description # Conflicts: # composeApp/src/androidMain/kotlin/it/fast4x/rimusic/ui/screens/localplaylist/LocalPlaylistSongs.kt # composeApp/src/androidMain/res/values/strings.xml
|
Wait new version and try again, also because some files are changed or deleted. |
|
I added a setting for it in |
|
@fast4x this is ready to be merged |
|
yes i know, |
|
Sorry, didn't see that, but it is resolved now |
|
This code not convinced me, i mean description for personal online playlist and where is placed, actually many code in playlist was changed, i want to wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I redid #4586 (which comes from #4566) but I am not sure whether I need to add my code from
LocalPlaylistSongsModern.ktto the other Playlist files likeLocalPlaylistSongsModern.kt,PlaylistScreen.ktorPlaylistSongList.kt.This feature did not work for a long while and I couldn't get my head around why this was the case until i found out, that @fast4x set
description = nullin 4507678#diff-54495b67b89955311e53b5b88e6ab47e6f4b1a496d784bbf8acda0c2579c8e87R187 and I don't know why...Also, the fetching is pretty slow, so you will notice it like shown here:
Screen_recording_20250131_185059.webm
And I think, that I should implement a toggle for this in the settings, because I can see people get annoyed with it.