implemented "dislike" by long-tap & related fixes #5180
+455
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twistios
changed the title
# Conflicts: # composeApp/src/androidMain/kotlin/it/fast4x/rimusic/ui/screens/player/components/controls/Essential.kt
- similar to `setLikeState`, but for disliking
- now uses `setDislikeState`, i.e. changes the value depending on the current value
|
I am working on toggling between disliked and "unliked". |
- removed `dislike` from database as not needed anymore - implemented toggling similar to like-toggle via `setDisLikeState`
# Conflicts: # composeApp/src/androidMain/kotlin/it/fast4x/rimusic/ui/screens/player/components/controls/Essential.kt
- did not work properly with disliked songs - was automatically unliking songs if they where not in the db (so it seemed not to do anything on the first tap) - added `getLikedAt` as was required (likedAt returns a flow)
- like a song if it was unliked/disliked - insert the song into the db if it was not there
- also added smart message feedback to `AlbumDetails`, `LocalPlayListSongsModern`
- directly via long-tap (skipping the step via single-tap cycling)
- also improved related code
- InfoAlbumAndArtistEssential/-Modern: single tap now is consistent with long tap (also does not dislike anymore) - ControlsEssential: additionally (to changes in previous item) implemented autodownload-on-like
- now does not consider disliked songs as liked
twistios
changed the title
- now don't consider disliked songs as liked
|
This pull request also fixes autodownload, more toast message feedback, implements dislike in gridmenu where it was not previously existing. I guess there are still more places missing where dislike is missing/not consistent with this changes (maybe history, ...) |
# Conflicts: # composeApp/src/androidMain/kotlin/it/fast4x/rimusic/ui/components/themed/MediaItemGridMenu.kt # composeApp/src/androidMain/kotlin/it/fast4x/rimusic/ui/components/themed/MediaItemMenu.kt # composeApp/src/androidMain/kotlin/it/fast4x/rimusic/ui/screens/album/AlbumDetails.kt # composeApp/src/androidMain/kotlin/it/fast4x/rimusic/ui/screens/playlist/PlaylistSongList.kt
|
Another fix included is that disliked songs do not show as liked songs anymore. |
# Conflicts: # composeApp/src/androidMain/kotlin/it/fast4x/rimusic/ui/components/themed/MediaItemMenu.kt # composeApp/src/androidMain/kotlin/it/fast4x/rimusic/ui/screens/album/AlbumDetails.kt # composeApp/src/androidMain/kotlin/it/fast4x/rimusic/ui/screens/localplaylist/LocalPlaylistSongsModern.kt # composeApp/src/androidMain/kotlin/it/fast4x/rimusic/ui/screens/playlist/PlaylistSongList.kt
- new type for `BuildInPlayList`
- implemented database methods for disliked-tab
- sort by: playtime, relative playtime, (song) title, rowId, date played, artist, duration, album name
- implemented SortOrder.toSQLString to be able to reduce number of methods
- songsDisliked: "combination method"
- adapted `HomeSongsModern` to support disliked songs
- implemented a settings item for disliked tab
- adapted code to be compatible with long-tap disliking - improved liking related code - other small changes
- applied `cleanPrefix` on the song title
- did use the icon for unliked - it showed the wrong message if the song went from disliked->liked
- added support for dislike-icon - implemented dislike by long-tap (incl. auto-deleting on dislike in case auto-download is enabled) - unliking in case of synced (can currently not implement disliking in YTM)
|
The disliked songs tab is implemented. Also changes for mini-player are included. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is by @aneesh1122.