Skip to content

docs: add fastrace-architecture.png to img #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

docs: add fastrace-architecture.png to img #35

wants to merge 1 commit into from

Conversation

ethercflow
Copy link
Contributor

No description provided.

@andylokandy andylokandy changed the title doc(img): add fastrace-architecture.png to img docs(img): add fastrace-architecture.png to img Sep 2, 2024
Xuanwo
Xuanwo reviewed Sep 2, 2024
View reviewed changes
etc/img/fastrace-architecture.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.53 MB is quite large for our repository. How about using GitHub's native mermaid support to draw it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First time learning about mermaid, looks cool. I'll give it a try. Thanks!

@andylokandy andylokandy changed the title docs(img): add fastrace-architecture.png to img docs: add fastrace-architecture.png to img Sep 2, 2024
@andylokandy
Copy link
Collaborator

@Xuanwo Is there any reason that we need to concern about the size?

@Xuanwo
Copy link
Collaborator

Xuanwo commented Nov 8, 2024

@Xuanwo Is there any reason that we need to concern about the size?

It's not just about size. Images like this one are really hard to read. We could either break it into multiple pieces to make it easier to read and understand, or we could use mermaid to make it more interactive. Otherwise, we'll end up with something like this:

image

@ethercflow
Copy link
Contributor Author

@andylokandy @Xuanwo Sorry, I've been really busy lately. How about we close this PR for now and I'll reopen it when I'm ready?

@Xuanwo
Copy link
Collaborator

Xuanwo commented Nov 8, 2024

@andylokandy @Xuanwo Sorry, I've been really busy lately. How about we close this PR for now and I'll reopen it when I'm ready?

Thank you very much, @ethercflow, for working on this. I think we can set this PR to draft first.

@Xuanwo Xuanwo marked this pull request as draft November 8, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ethercflow @andylokandy @Xuanwo