Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose MapInstanceManager and the default projection settings at window.farmOS.map #122

Merged

Conversation

symbioquine
Copy link
Collaborator

Why? Make usage via import statements more consistent with the simple browser usage and enable externalizing to window.farmOS.map.

…ow.farmOS.map farmOS#122

**Why?** Make usage via `import` statements more consistent with
the simple browser usage and enable externalizing to
`window.farmOS.map`.
@symbioquine
Copy link
Collaborator Author

@jgaehring I'd love your thoughts on how well the changes here and in #117 have addressed the concerns you previously voiced about how farmOS-map is packaged and (with 1.x) needed to be consumed via window.farmOS.map or a import statement that directly referenced the farmOS-map src/.

@jgaehring
Copy link
Member

So happy to see this going forward, @symbioquine! 👏

I think I need dedicate some time to getting up to speed on what's been done here and in #117 before I can meaningfully weigh in. I'm putting aside some time tomorrow afternoon to do so. I'll post back here with my initial thoughts after that and perhaps we can follow up in the monthly call this Wed, if you can make it, or some other time.

@symbioquine
Copy link
Collaborator Author

Thanks @jgaehring! That sounds great, I should be on the Wednesday call.

@jgaehring
Copy link
Member

Oh this looks great, @symbioquine! I'm just about at the point where I can try this out in Field Kit this week or next, but from what I can tell looking at the diffs, this is a huge improvement. So glad you're giving this project the attention it needs!

@paul121
Copy link
Member

paul121 commented Jun 18, 2021

👍 @symbioquine @jgaehring and myself just discussed and agreed to merge this in to the 2.x branch. Then we can tag a 2.0.0 alpha release which will unblock next steps in #115

@symbioquine symbioquine merged commit 4b82f81 into farmOS:2.x Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants