Skip to content

Commit

Permalink
chore: deprecate python 3.5 (aws#186)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Removes Testing against Python 3.5. Python 3.5 is no longer supported by the Python AWS DynamoDB Encryption Client.
  • Loading branch information
texastony authored Nov 9, 2021
1 parent f8e258e commit 846e3b1
Show file tree
Hide file tree
Showing 7 changed files with 3 additions and 39 deletions.
1 change: 0 additions & 1 deletion .github/workflows/ci_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ jobs:
- os: macos-latest
architecture: x64
python:
- 3.5
- 3.6
- 3.7
- 3.8
Expand Down
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ Getting Started
Required Prerequisites
======================

* Python 3.5+
* Python 3.6+


Installation
Expand Down
2 changes: 0 additions & 2 deletions buildspec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ version: 0.2
batch:
fast-fail: false
build-list:
- identifier: python3_5
buildspec: codebuild/python3.5.yml
- identifier: python3_6
buildspec: codebuild/python3.6.yml
- identifier: python3_7
Expand Down
32 changes: 0 additions & 32 deletions codebuild/python3.5.yml
Original file line number Diff line number Diff line change
@@ -1,32 +0,0 @@
version: 0.2

env:
variables:
TOXENV: "py35-integ-slow"
AWS_ENCRYPTION_SDK_PYTHON_INTEGRATION_TEST_AWS_KMS_KEY_ID: >-
arn:aws:kms:us-west-2:658956600833:key/b3537ef1-d8dc-4780-9f5a-55776cbb2f7f
AWS_ENCRYPTION_SDK_PYTHON_INTEGRATION_TEST_AWS_KMS_KEY_ID_2: >-
arn:aws:kms:eu-central-1:658956600833:key/75414c93-5285-4b57-99c9-30c1cf0a22c2
phases:
install:
runtime-versions:
python: latest
build:
commands:
# The specific versions are manually installed
# because they are not installed
# by default in CodeBuild containers.
# `pyenv` does not have
# a nice way to just install
# the latest patch version.
# I have selected the current latest patch
# rather than try
# and manage a one-liner or script.
# Testing every minor version
# is too extreme at this time.
# The choice of versions should be reviewed.
- pyenv install 3.5.10
- pyenv local 3.5.10
- pip install tox tox-pyenv
- tox
2 changes: 1 addition & 1 deletion examples/tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

[tox]
envlist =
py{27,35,36,37,38,39}-examples
py{36,37,38,39}-examples

[testenv:base-command]
commands = python -m pytest --basetemp={envtmpdir} -l {posargs}
Expand Down
1 change: 0 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ def get_requirements():
"License :: OSI Approved :: Apache Software License",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.5",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tox]
envlist =
py{35,36,37,38,39,310}-{local,integ,ddb,examples}-fast,
py{36,37,38,39,310}-{local,integ,ddb,examples}-fast,
nocmk, sourcebuildcheck,
docs, bandit, doc8, readme,
flake8{,-tests,-examples}, pylint{,-tests,-examples},
Expand Down

0 comments on commit 846e3b1

Please sign in to comment.