-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp numeric text field #550
Conversation
This SHOULD fix bug farirpgs#414, in a way that doesn't look too bad.
Just tested, the UI looks fine! Though we'd need to disable the logic to prevent the 999 cap here: https://github.com/glmdgrielson/fari-app/blob/9900754feb3c207fc04dd695825810e3f64134d8/lib/routes/Character/components/CharacterDialog/components/CircleTextField.tsx#L95-L109 and probably change this forced with of 3rem here: https://github.com/glmdgrielson/fari-app/blob/9900754feb3c207fc04dd695825810e3f64134d8/lib/routes/Character/components/CharacterDialog/components/CircleTextField.tsx#L113-L114 |
One other thing that might need fixing, this warning:
|
The whole point was to stop doing that, after all.
Now to hope that this actually looks decent.
Alright, both of the issues you brought up have been fixed. (I can't believe I forgot to remove the code that causes literally the very issue I was supposed to be solving the whole time.) |
I could have sworn that read "background-color". Apparently it didn't. WHOOPS! Well, that's fixed now.
This SHOULD fix bug #414, in a way that doesn't look too bad.
β Changes
π Context
Per bug #414, the prior version had a limit on how large the value in the field could be.
πChecklist