feat: add option to pass client url when initializing relayer channel #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[draft to explain the concept, not a fully baked PR]
Motivation
As it currently exists, the only client supported by the Warpcast relay servers is the Warpcast app, redirecting all auth requests to
https://warpcast.com/~/sign-in-with-farcaster
. Apps like Supercast currently have no way to have other apps SIWF unless they export a seed phrase and import that into the Warpcast app.This PR adds some light flexibility to this by allowing the implementing page to specify the target client URL
This PR does not address any larger issues around assembling a registry or require handling. It currently does not recommend any changes to AuthKit itself - implementation of passing in the client URL is up to individual implementers to start.
Change Summary
Instead of pulling from env, channel creation is updated to support passing in a client URL when initializing the channel. An example of how this could be used:
Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewAdditional Context
If this is a relatively large or complex change, provide more details here that will help reviewers