ignore columns defined as string

faraazahmad · Aug 6, 2023 · e1ac572 · e1ac572
1 parent 2c34416
commit e1ac572
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 8 deletions.
diff --git a/lib/trains/utils/migration_tailor.rb b/lib/trains/utils/migration_tailor.rb
@@ -19,6 +19,8 @@ def self.stitch(models = {}, migrations)
             end
           when :add_column, :add_column_with_default, :add_reference
             models[mig.table_name].fields.push(*mig.fields)
+          when :ignore_column
+            models[mig.table_name].ignored_columns.push(*mig.fields.map(&:name))
           when :remove_column
             column =
               models[mig.table_name].fields.find do |field|

diff --git a/lib/trains/visitor/model.rb b/lib/trains/visitor/model.rb
@@ -39,13 +39,13 @@ def parse_model(node)
 
           arguments = node.arguments.first.to_a
           arguments = arguments.select do |child|
-            child.is_a?(RuboCop::AST::SymbolNode)
+            child.is_a?(RuboCop::AST::SymbolNode) || child.is_a?(RuboCop::AST::StrNode)
           end.map(&:value)
 
           @result << DTO::Migration.new(
             @model_class,
             :ignore_column,
-            [*arguments.map { |arg| DTO::Field.new(arg, nil) }],
+            [*arguments.map { |arg| DTO::Field.new(arg.to_sym, nil) }],
             nil
           )
 

diff --git a/spec/lib/trains/visitor/model_spec.rb b/spec/lib/trains/visitor/model_spec.rb
@@ -14,12 +14,16 @@ class AccountPin < ApplicationRecord
 
       expect(parser.result).to eq(
         [
-        Trains::DTO::Migration.new(
-          table_name: 'AccountPin',
-          modifier: :ignore_column,
-          fields: [Trains::DTO::Field.new(:foo, nil), Trains::DTO::Field.new(:baz, nil)],
-          version: nil
-        )
+          Trains::DTO::Migration.new(
+            table_name: 'AccountPin',
+            modifier: :ignore_column,
+            fields: [
+              Trains::DTO::Field.new(:foo, nil),
+              Trains::DTO::Field.new(:baz, nil),
+              Trains::DTO::Field.new(:what, nil)
+            ],
+            version: nil
+          )
         ]
       )
     end