Update ColorPicker.pb #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed scrollwheel bug in named colorpicker.
t-harter
reviewed
Dec 19, 2024
PureBasicIDE/ColorPicker.pb
Outdated
| @@ -1114,6 +1114,18 @@ Procedure ColorPicker_Name_Event(*Entry.ColorPickerData, Gadget, Type) | |||
| EndIf | |||
|
|
|||
| Case #GADGET_Color_Canvas1 | |||
| If Type = #PB_EventType_MouseWheel | |||
| *Entry\First - GetGadgetAttribute(#GADGET_Color_Canvas1 , #PB_Canvas_WheelDelta) | |||
There was a problem hiding this comment.
That is a little bit too much with the spaces 😃 The convention for function parameters is to have one space after the comma, but none before it:
GetGadgetAttribute(#GADGET_Color_Canvas1, #PB_Canvas_WheelDelta)
There was a problem hiding this comment.
Yes I see that :-) , now I have fixed that and clicked commit here on Github, do I now have to submit a new pull request?
Scrollwheel support for Named Colorpicker
|
@ErlendRovik no, just push the commits to the same branch, which you seemingly have already done. |
fantaisie-software
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed scrollwheel bug in named colorpicker.