Skip to content

Adjust docker composes #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2025
Merged

Adjust docker composes #794

merged 1 commit into from
Apr 26, 2025

Conversation

nkiryanov
Copy link
Contributor

Тут чуть-чуть подкручиваю compose.yml:

  1. Не понял зачем в проект добавили второй docker-compose.db.yml, его дропаю чтоб не смущал
  2. Вынес дефолтные настройки отдельно: кажется так лучше читается
  3. Переименовал docker-compose.yml → compose.yml так как по дефолту теперь так называется

nkiryanov
nkiryanov commented Apr 23, 2025
View reviewed changes
{{ cookiecutter.name }}/docker-compose.db.yml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vlkpn глянь тоже плз — тут удаляю добавленный в #784. Кажется он ни к чему — предполагаю, что тот, кто пользуется шаблоном просто может удалить из compose.yml лишнее

@nkiryanov nkiryanov requested a review from kazqvaizer April 23, 2025 17:41
@nkiryanov nkiryanov changed the base branch from migrate-to-uv to master April 26, 2025 12:27
@nkiryanov nkiryanov force-pushed the adjust-docker-compose branch from c357e19 to 906faed Compare April 26, 2025 12:29
@nkiryanov nkiryanov enabled auto-merge (squash) April 26, 2025 12:31
@nkiryanov nkiryanov merged commit d32f758 into master Apr 26, 2025
3 checks passed
@nkiryanov nkiryanov deleted the adjust-docker-compose branch April 26, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazqvaizer kazqvaizer kazqvaizer approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkiryanov @kazqvaizer