Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some functionality for filtering attendances records #137

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

agn-7
Copy link

@agn-7 agn-7 commented Mar 12, 2022

  • sorting attendances records by date or by user-id
  • limiting attendances records by date or by user-id
  • getting user history

@Ukhupacha
Copy link

Can this branch be merged? It its a really good implementation for filtering dates.

Copy link

@Reem-Elfalah Reem-Elfalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please review this and add it as the features are really helpful when downloading huge data

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_limited_attendance accepts start_date & end_date not start & end, please fix it in the README, thanks!!

def get_limited_attendance(
self, users: list = [],
start_date=None, end_date=None
) -> list:

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's done!

@ysystech
Copy link

Hi. @agn-7 . Thank you so much for this update. I hope that this will be merged in the main branch.

@ysystech
Copy link

By the way, I have some question, do you an experience connecting with ZkTeco WL20 device? It returns empty list when I call get_attenance() or get_users() functions.

This is an old forum but still not resolved til today.

#76

@novaprime-code
Copy link

please merge this PR its really usefull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants