Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(watchlist): Add media to watchlist #374

Merged
merged 5 commits into from
Jun 5, 2023
Merged

feat(watchlist): Add media to watchlist #374

merged 5 commits into from
Jun 5, 2023

Conversation

yalagin
Copy link
Contributor

@yalagin yalagin commented Apr 27, 2023 •
edited
Loading

feat(add watchlist): adding missing functionality from Overseerr

Description

This issue aims to add watchlist functionality to Jellyseerr, addressing its current absence. Watchlists allow users to create and manage personalized collections of movies, TV shows, and other media. By integrating this missing feature into Jellyseerr's list view, users can easily add, remove, and organize their preferred content. The addition of watchlists will enhance the user experience, providing a convenient way to track and discover new media within Jellyseerr.

Screenshot (if UI-related)

Screenshot 2023-04-27 at 22 33 51

To-Dos

  • add watchlist button to media page

@yalagin
feat(add watchlist): adding midding functionality from overserr
5f1c10d 
feat(add watchlist): adding missing functionality from overserr
@yalagin yalagin requested a review from fallenbagel as a code owner April 27, 2023 15:35
@yalagin yalagin changed the title feat(add watchlist): adding midding functionality from overserr feat(add watchlist): adding missing functionality from overserr. Add media to watchlist Apr 27, 2023
@yalagin yalagin changed the title feat(add watchlist): adding missing functionality from overserr. Add media to watchlist feat(add watchlist): adding missing functionality from overseerr. Add media to watchlist Apr 27, 2023
@yalagin yalagin changed the title feat(add watchlist): adding missing functionality from overseerr. Add media to watchlist feat(watchlist): Add media to watchlist Apr 27, 2023
@fallenbagel
Copy link
Owner

Wait watchlist was missing? 🤔
I didnt realise though I have been merging from upstream to keep feature parity

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 27, 2023
View reviewed changes
server/entity/Watchlist.ts
Comment on lines +103 to +108
let media = await mediaRepository.findOne({
where: {
tmdbId: watchlistRequest.tmdbId,
mediaType: watchlistRequest.mediaType,
},
});

Check failure

Code scanning / CodeQL

NoSQL database query built from user-controlled sources (experimental)

(Experimental) This may be a database query that depends on [a user-provided value](1). Identified using machine learning.
server/routes/watchlist.ts Outdated
Comment on lines 30 to 33
logger.warn('Something wrong with data watchlist', {
...req.body,
label: 'Watchlist',
});

Check failure

Code scanning / CodeQL

Log injection

Log entry depends on a [user-provided value](1).
@yalagin
Copy link
Contributor Author

yalagin commented Apr 27, 2023

Well it's not missing it's not available for Jellyfin users. I want to bookmark some media for future downloads. In plex its called watchchlist. So I decided to add watchlist functionality to jellyseerr.

@fallenbagel
Copy link
Owner

Well it's not missing it's not available for Jellyfin users. I want to bookmark some media for future downloads. In plex its called watchchlist. So I decided to add watchlist functionality to jellyseerr.

Wait how would watchlist work for jellyfin users? Won't they need a plex server?

@yalagin
Copy link
Contributor Author

yalagin commented Apr 27, 2023 •
edited
Loading

no they dont need plex server
you can press star on media
Screenshot 2023-04-28 at 00 49 10
it will add it to watchlist in database
Screenshot 2023-04-28 at 00 50 37
you can press minus to delete media from watchlist
instead of loading it from plex server we will load it from sql database that jellyseerr using already

@fallenbagel
Copy link
Owner

no they dont need plex server
you can press star on media
Screenshot 2023-04-28 at 00 49 10
it will add it to watchlist in database
Screenshot 2023-04-28 at 00 50 37
you can press minus to delete media from watchlist
instead of loading it from plex server we will load it from sql database that jellyseerr using already

OOO I LOVE THIS! Thank you so much for the PR! I'll review it soon. 2 tests seems to have failed I'll have a look at it tomorrow in the morning

fallenbagel
fallenbagel approved these changes Jun 5, 2023
View reviewed changes
Copy link
Owner

@fallenbagel fallenbagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@fallenbagel fallenbagel merged commit 21c1bbe into fallenbagel:develop Jun 5, 2023
@fallenbagel
Copy link
Owner

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Codename-11
Copy link

How does one view the items added to the watchlist? I use Jellyfin, which I know doesn't have a watchlist functionality built in...

@Cavonzio
Copy link

How does one view the items added to the watchlist? I use Jellyfin, which I know doesn't have a watchlist functionality built in...

They should add a watchlist menu in jellyseer, otherwise this is confusing for jellyfin users

@fallenbagel
Copy link
Owner

How does one view the items added to the watchlist? I use Jellyfin, which I know doesn't have a watchlist functionality built in...

They should add a watchlist menu in jellyseer, otherwise this is confusing for jellyfin users

#527

you can now press your watchlist slider and expand to see all your watchlists. In addition, if the user has View Watchlists permission, they can see others watchlists from the profile (admin should be able to see everyones)

@fallenbagel
Copy link
Owner

@all-contributors please add @yalagin for code

@allcontributors allcontributors bot mentioned this pull request Nov 7, 2023
Merged
@allcontributors AllContributors
Copy link
Contributor

@fallenbagel

I've put up a pull request to add @yalagin! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fallenbagel fallenbagel fallenbagel approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yalagin @fallenbagel @Codename-11 @Cavonzio