fix:Removed unused variables, WatchlistSyncMusic column and multiples…

… bug fixed

server/api/musicbrainz/index.ts

@@ -107,14 +107,12 @@ class MusicBrainz extends ExternalAPI {
             ? await this.get<MbAlbumDetails>(`/album/${id}`, { language }, 43200)
             : await this.get<MbArtistDetails>(`/artist/${id}`, { language }, 43200);
 
-        // Get the appropriate links
         let targetLinks: MbLink[] | undefined;
         if (type === 'album') {
             const albumData = data as MbAlbumDetails;
             const artistId = albumData.artists?.[0]?.id;
             if (!artistId) return null;
 
-            // Get artist details to access links
             const artistData = await this.get<MbArtistDetails>(`/artist/${artistId}`, { language }, 43200);
             targetLinks = artistData.links;
         } else {
@@ -170,6 +168,7 @@ class MusicBrainz extends ExternalAPI {
         if (!extract) return null;
 
         const decoded = extract
+            .replace(/<script[\s\S]*?>[\s\S]*?<\/script>/gi, '')
             .replace(/\\u[\dA-F]{4}/gi, match =>
                 String.fromCharCode(parseInt(match.replace(/\\u/g, ''), 16))
             )

server/entity/UserSettings.ts

@@ -72,9 +72,6 @@ export class UserSettings {
   @Column({ nullable: true })
   public watchlistSyncTv?: boolean;
 
-  @Column({ default: false })
-  public watchlistSyncMusic?: boolean;
-
   @Column({
     type: 'text',
     nullable: true,

server/lib/search.ts

@@ -24,10 +24,6 @@ import {
   isMovie,
   isMovieDetails,
   isTvDetails,
-  isArtist,
-  isAlbum,
-  isArtistDetails,
-  isAlbumDetails
 } from '@server/utils/typeHelpers';
 
 

server/routes/person.ts

@@ -71,6 +71,7 @@ personRoutes.get('/:id', async (req, res, next) => {
 
 personRoutes.get('/:id/discography', async (req, res, next) => {
   const musicBrainz = new MusicBrainz();
+  const tmdb = new TheMovieDb();
   const coverArtArchive = new CoverArtArchive();
   const artistId = req.query.artistId as string;
   const type = req.query.type as string;
@@ -84,6 +85,19 @@ personRoutes.get('/:id/discography', async (req, res, next) => {
     });
   }
 
+  const person = await tmdb.getPerson({
+    personId: Number(req.params.id),
+    language: (req.query.language as string) ?? req.locale,
+  });
+
+  if (!person.birthday) {
+    return res.status(200).json({
+      page: 1,
+      pageInfo: { total: 0, totalPages: 0 },
+      results: [],
+    });
+  }
+
   try {
     const artistDetails = await musicBrainz.getArtist({
       artistId: artistId,

server/routes/search.ts

@@ -25,7 +25,6 @@ searchRoutes.get('/', async (req, res, next) => {
         language: (req.query.language as string) ?? req.locale,
         query: queryString,
       });
-      combinedResults = results.results;
     } else {
       const tmdb = new TheMovieDb();
       const tmdbResults = await tmdb.searchMulti({

server/routes/settings/index.ts

@@ -47,7 +47,7 @@ const settingsRoutes = Router();
 settingsRoutes.use('/notifications', notificationRoutes);
 settingsRoutes.use('/radarr', radarrRoutes);
 settingsRoutes.use('/sonarr', sonarrRoutes);
-settingsRoutes.use('/lidarr', lidarrRoutes)
+settingsRoutes.use('/lidarr', lidarrRoutes);
 settingsRoutes.use('/discover', discoverSettingRoutes);
 
 const filteredMainSettings = (

src/components/MusicDetails/index.tsx

@@ -46,6 +46,7 @@ const messages = defineMessages('components.MusicDetails', {
   managemusic: 'Manage Music',
   biographyunavailable: 'Biography unavailable.',
   trackstitle: 'Tracks',
+  tracksunavailable: 'No tracks available.',
   watchlistSuccess: '<strong>{title}</strong> added to watchlist successfully!',
   watchlistDeleted: '<strong>{title}</strong> removed from watchlist successfully!',
   watchlistError: 'Something went wrong try again.',
@@ -512,35 +513,39 @@ const MusicDetails = ({ music }: MusicDetailsProps) => {
               : intl.formatMessage(messages.biographyunavailable)}
           </p>
           <h2 className="py-4">{intl.formatMessage(messages.trackstitle)}</h2>
-          {data.releases[0].tracks && (
+          {data.releases?.[0]?.tracks?.length > 0 ? (
             <div className="divide-y divide-gray-700 rounded-lg border border-gray-700">
               {data.releases[0].tracks.map((track, index) => (
                 <div
-                  key={track.id}
+                  key={track.id ?? index}
                   className="flex items-center justify-between px-4 py-2 text-sm transition duration-150 hover:bg-gray-700"
                 >
                   <div className="flex flex-1 items-center space-x-4">
                     <span className="w-8 text-gray-500">{index + 1}</span>
                     <span className="flex-1 truncate text-gray-300">{track.trackName}</span>
                     <span className="text-right text-gray-500">
-                      {Math.floor((track.durationMs / 1000) / 60)}:
-                      {String(Math.floor((track.durationMs / 1000) % 60)).padStart(2, '0')}
+                      {Math.floor((track.durationMs ?? 0) / 1000 / 60)}:
+                      {String(Math.floor((track.durationMs ?? 0) / 1000 % 60)).padStart(2, '0')}
                     </span>
                   </div>
                 </div>
               ))}
             </div>
+          ) : (
+            <div className="text-gray-400">
+              {intl.formatMessage(messages.tracksunavailable)}
+            </div>
           )}
         </div>
         <div className="media-overview-right">
           <div className="media-facts">
-            {data.releases[0].status && (
+            {data.releases?.[0]?.status && (
               <div className="media-fact">
                 <span>{intl.formatMessage(globalMessages.status)}</span>
                 <span className="media-fact-value">{data.releases[0].status}</span>
               </div>
             )}
-            {data.releases[0].label?.length > 0 && (
+            {data.releases?.[0]?.label?.length > 0 && (
               <div className="media-fact">
                 <span>{intl.formatMessage(messages.label)}</span>
                 <span className="media-fact-value">

src/i18n/locale/en.json

@@ -329,6 +329,7 @@
   "components.MusicDetails.managemusic": "Manage Music",
   "components.MusicDetails.biographyunavailable": "Biography unavailable.",
   "components.MusicDetails.trackstitle": "Tracks",
+  "components.MusicDetails.tracksunavailable": "No tracks available.",
   "components.MusicDetails.watchlistSuccess": "<strong>{title}</strong> added to watchlist successfully!",
   "components.MusicDetails.watchlistDeleted": "<strong>{title}</strong> removed from watchlist successfully!",
   "components.MusicDetails.watchlistError": "Something went wrong try again.",