Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: bpf cmd format #208

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Update: bpf cmd format #208

merged 2 commits into from
Feb 29, 2024

Conversation

Rohith-Raju
Copy link
Contributor

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area rules

Proposed rule maturity level

/area maturity-sandbox

What this PR does / why we need it:

This PR updates new bpf cmd format based on changes implemented in falcosecurity/libs#1545

Which issue(s) this PR fixes:

Fixes #203

Special notes for your reviewer:

@poiana poiana added dco-signoff: yes kind/bug Something isn't working area/rules area/maturity-sandbox See the Rules Maturity Framework labels Dec 19, 2023
@poiana poiana requested review from darryk10 and Kaizhe December 19, 2023 05:44
@poiana poiana added the size/XS label Dec 19, 2023
Copy link

Rules files suggestions

falco-sandbox_rules.yaml

Comparing 88e580cedcb33d81f692882fb07c2fb6f8b16c61 with latest tag falco-sandbox-rules-2.0.0

No changes detected

@incertum
Copy link
Contributor

Thanks @Rohith-Raju ❤️

/hold for a while since we won't have that until libs 0.15.0 and the next Falco release will use libs 0.14.x

Anticipate to hold it until at least February / March.

@Rohith-Raju
Copy link
Contributor Author

Sounds good!! @incertum

@leogr
Copy link
Member

leogr commented Jan 18, 2024

Anticipate to hold it until at least February / March.

Reminder: we will also need to update required_engine_version accordingly.

@incertum
Copy link
Contributor

@Rohith-Raju we finally have the libs changes in Falco master, please bump the required_engine_version to 0.35.0 in the rules file you touched, see https://github.com/falcosecurity/falco/blob/master/userspace/engine/falco_engine_version.h#L23 plus a rebase is needed. Thanks!

Copy link

Rules files suggestions

falco-sandbox_rules.yaml

Comparing 0530058deb7ef66c5912060d6c1dab1312de6cba with latest tag falco-sandbox-rules-3.0.1

No changes detected

Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@leogr I let you decide when to merge via unholding this. Thanks.
From my perspective we are good to go since we recently made it more clear that the main branch has the latest development.

@poiana
Copy link

poiana commented Feb 27, 2024

LGTM label has been added.

Git tree hash: b21dd8d81418e7506c9949596d664c90ac8177e2

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

/hold cancel

Note: This change makes this ruleset compatible with Falco 0.38 and up only.

@poiana
Copy link

poiana commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: incertum, leogr, Rohith-Raju

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 2ded9e2 into falcosecurity:main Feb 29, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update rule "BPF Program Not Profiled" with new bpf cmd format
4 participants