fix(plugin): match erase/add_entry behavior with libs #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the built-in libs tables, erasing a nonexistent entry is an error, while adding an entry that overwrites an already existing one is fine. Since there's no explicit spec for this, AFAICT, let's align our tables to that behavior as well. Signed-off-by: Grzegorz Nosek <[email protected]>
poiana
added
kind/bug
mrgian
approved these changes
Dec 16, 2024
|
LGTM label has been added. Git tree hash: 1a0b47367d1b686c2d93222eb6c2021d27975db6
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnosek, mrgian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the built-in libs tables, erasing a nonexistent entry is an error, while adding an entry that overwrites an already existing one is fine.
Since there's no explicit spec for this, AFAICT, let's align our tables to that behavior as well.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area plugin
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: