feat(userspace/libsinsp): improve recvmsg SCM_RIGHTS cmsg handling
#2262
+199
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonardo Di Giovanna <[email protected]>
poiana
added
release-note-none
kind/feature
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ekoops The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ekoops
changed the title
SCM_RIGHTS cmsg handlingrecvmsg SCM_RIGHTS cmsg handling
|
/milestone 0.21.0 |
Perf diff from master - unit testsHeap diff from master - unit testsHeap diff from master - scap fileBenchmarks diff from master |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2262 +/- ##
==========================================
- Coverage 75.34% 75.33% -0.02%
==========================================
Files 279 279
Lines 34368 34373 +5
Branches 5872 5872
==========================================
Hits 25894 25894
- Misses 8474 8479 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/hold |
ekoops
force-pushed
the
ekoops/scm-rights-procfs-scan
branch
4 times, most recently
from
05b2b33 to
9183259
Compare
Parse all control messages instead of parsing just the first one. Leverage the new scap_get_fdinfo API to get info only from the file in procfs associated to the file descriptor, instead of scanning each time the entire procfs fd directory. Signed-off-by: Leonardo Di Giovanna <[email protected]>
ekoops
force-pushed
the
ekoops/scm-rights-procfs-scan
branch
from
9183259 to
c7f02ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area libscap-engine-gvisor
/area libscap
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This enhances file descriptor handling in the context of
SCM_RIGHTScontrol message processing forrecvmsgevents. Specifically:cmsghdrand all file descriptors contained inSCM_RIGHTScontrol messages, by selectively call the new API on them, instead of entirely scanning the entire procfs fd directory each time.readlink + sscanfcalls with a single call tostatfor retrieving the inode number of a network namespace inscap_fd_scan_fd_dirandscap_fd_get_fdinfoWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: