Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: update(ci): use CNCF oracle gh runners #2200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind cleanup

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area CI

Does this PR require a change in the driver versions?

No

What this PR does / why we need it:

Updating the runner should mean faster builds and hopefully tests not hanging.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana
Copy link
Contributor

poiana commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Perf diff from master - unit tests

    10.01%     -0.99%  [.] sinsp::next
     2.30%     -0.72%  [.] scap_event_decode_params
     4.41%     +0.59%  [.] gzfile_read
     3.59%     -0.48%  [.] sinsp_thread_manager::get_thread_ref
     1.04%     +0.44%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::find
     5.61%     +0.42%  [.] next_event_from_file
     3.53%     +0.42%  [.] sinsp_evt::load_params
     9.43%     +0.34%  [.] sinsp_parser::reset
     8.20%     +0.29%  [.] sinsp_evt::get_type
     0.07%     +0.28%  [.] std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<std::pair<long const, std::shared_ptr<sinsp_fdinfo> >, false> > >::_M_allocate_node<long&, std::unique_ptr<sinsp_fdinfo, std::default_delete<sinsp_fdinfo> > >

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0104         -0.0104           152           150           152           150
BM_sinsp_split_median                                          -0.0132         -0.0132           152           150           152           150
BM_sinsp_split_stddev                                          -0.3565         -0.3567             2             1             2             1
BM_sinsp_split_cv                                              -0.3498         -0.3500             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0928         +0.0928            57            62            57            62
BM_sinsp_concatenate_paths_relative_path_median                +0.0912         +0.0912            57            62            57            62
BM_sinsp_concatenate_paths_relative_path_stddev                -0.5863         -0.5869             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.6214         -0.6219             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0318         +0.0318            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_median                   +0.0317         +0.0317            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_stddev                   +0.6716         +0.6705             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +0.6201         +0.6190             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.1614         +0.1614            56            65            56            65
BM_sinsp_concatenate_paths_absolute_path_median                +0.1581         +0.1581            56            65            56            65
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.3692         -0.3693             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.4569         -0.4569             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0375         +0.0375           382           397           382           397
BM_sinsp_split_container_image_median                          +0.0384         +0.0384           383           397           383           397
BM_sinsp_split_container_image_stddev                          +0.6254         +0.6271             2             3             2             3
BM_sinsp_split_container_image_cv                              +0.5667         +0.5683             0             0             0             0

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.19%. Comparing base (34cbe7e) to head (54840ac).
Report is 30 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2200   +/-   ##
=======================================
  Coverage   75.19%   75.19%           
=======================================
  Files         261      261           
  Lines       33878    33878           
  Branches     5801     5801           
=======================================
  Hits        25475    25475           
  Misses       8403     8403           
Flag Coverage Δ
libsinsp 75.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucaGuerra
Copy link
Contributor Author

well yes of course this uses Oracle Linux Kernel which does not have headers available for debian 🤦

@FedeDP
Copy link
Contributor

FedeDP commented Dec 16, 2024

well yes of course this uses Oracle Linux Kernel which does not have headers available for debian 🤦

Yep that's why i used the other runners :D

@Andreagit97 Andreagit97 added this to the TBD milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants