Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(driver): fixed build against linux v6.7-rc4. #1566

Merged
merged 4 commits into from
Dec 18, 2023
Merged

fix(driver): fixed build against linux v6.7-rc4. #1566

merged 4 commits into from
Dec 18, 2023

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Dec 12, 2023

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area driver-kmod
/area driver-bpf
/area driver-modern-bpf

Does this PR require a change in the driver versions?

/version driver-API-version-patch

What this PR does / why we need it:

Fixes drivers build against linux v6.7-rc4+.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(driver): fixed build against linux 6.7

@poiana poiana requested review from hbrueckner and mstemm December 12, 2023 09:00
@poiana poiana added the size/M label Dec 12, 2023
@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 12, 2023

I was able to locally build drivers.
The CI driverkit job is failig weirdly: https://github.com/falcosecurity/libs/actions/runs/7178620051.
I can repro it locally and am trying to understand what's happening.

@github-actions GitHub Actions
Copy link

Please double check driver/API_VERSION file. See versioning.

/hold

@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 12, 2023

Bumped api version patch.
/unhold

@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 12, 2023

/milestone next-driver

I think we should merge this for the next-driver milestone otherwise Falco 0.37 will ship a driver that won't run on kernel 6.7 that is going to be released in 2-3 weeks (ie: before the Falco release...).

@poiana poiana added this to the next-driver milestone Dec 12, 2023
@Andreagit97 Andreagit97 mentioned this pull request Dec 12, 2023
Merged
@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 12, 2023

Need to rebase once #1567 is in.

@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 12, 2023

Driverkit is now fixed: falcosecurity/driverkit#310
And a new patch release is coming: https://github.com/falcosecurity/driverkit/releases/tag/v0.16.2

@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 12, 2023

Rebased on top of master.

@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 12, 2023

CI is now passing against this branch (after the new driverkit patch release): https://github.com/falcosecurity/libs/actions/runs/7184655332/job/19566212831

incertum
incertum previously approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks @FedeDP 🚀 !

@poiana poiana added the lgtm label Dec 13, 2023
@Andreagit97
Copy link
Member

Andreagit97 commented Dec 13, 2023 •
edited
Loading

/hold until we are near the 6.7 release

The best thing would be to cherry-pick this on the release branch when the 6.7 is already out

@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 14, 2023

@alexellis do you know what can we do to install correct headers?
We need headers to build and test our kernel drivers, but CI is failing with:

E: Unable to locate package linux-headers-5.10.201
E: Couldn't find any package by glob 'linux-headers-5.10.201'

This is the same error we have in falcosecurity/falco#2961 too.

@poiana poiana added size/L and removed size/M labels Dec 14, 2023
@FedeDP FedeDP force-pushed the fix/build_v6.7 branch 2 times, most recently from 23b166d to c02d338 Compare December 15, 2023 07:51
@FedeDP FedeDP force-pushed the fix/build_v6.7 branch 3 times, most recently from 821f345 to e974187 Compare December 18, 2023 11:12
@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 18, 2023

/unhold

@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 18, 2023

Tested latest mainline kernel build against this branch: https://github.com/falcosecurity/libs/actions/runs/7247366053/job/19741136375 🟢 (6.7-rc6).

Andreagit97
Andreagit97 previously approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@FedeDP FedeDP mentioned this pull request Dec 18, 2023
Merged
Andreagit97
Andreagit97 approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, incertum, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,incertum,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit e4585f2 into master Dec 18, 2023
38 checks passed
@poiana poiana deleted the fix/build_v6.7 branch December 18, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@Andreagit97 Andreagit97 Andreagit97 approved these changes

@incertum incertum incertum left review comments

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@mstemm mstemm Awaiting requested review from mstemm

Assignees

@leogr leogr

@incertum incertum

@Andreagit97 Andreagit97

Labels
approved area/driver-bpf area/driver-kmod area/driver-modern-bpf dco-signoff: yes kind/bug Something isn't working lgtm release-note size/L
Projects
None yet
Milestone
7.0.0+driver
Development

Successfully merging this pull request may close these issues.
5 participants
@FedeDP @Andreagit97 @poiana @leogr @incertum