use a global method for the logs #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
do-not-merge/work-in-progress
kind/cleanup
dco-signoff: yes
kind/feature
cpanato
previously approved these changes
Jan 25, 2025
|
LGTM label has been added. Git tree hash: 7ff6ba43b376f7e13bf25c7211bc83d49696afec
|
Issif
force-pushed
the
feature/otlp-logs
branch
from
99d1e6a to
102c6f2
Compare
Issif
force-pushed
the
feature/otlp-logs
branch
from
102c6f2 to
c8c54ca
Compare
Issif
changed the title
Signed-off-by: Thomas Labarussias <[email protected]>
Issif
force-pushed
the
feature/otlp-logs
branch
from
c8c54ca to
4b8dff5
Compare
cpanato
approved these changes
Jan 27, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: e28de836c09abbecf1e14ad17947857bc2bc18b4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind feature
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
Use a global method for all logs + new output
OTLP LogsWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: