Refactor falco talon chart #765
Conversation
poiana
added
kind/cleanup
dco-signoff: yes
kind/feature
|
@leofvo: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @leofvo! It looks like this is your first PR to falcosecurity/charts 🎉 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LeoFVO The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ame for resources naming Uniformized the chart resources name and overwrite according to falco codebase Signed-off-by: LeoFVO <[email protected]>
leofvo
force-pushed
the
refactor-falco-talon-chart
branch
from
1029ece
to
500d1c2
Compare
|
Hey, this PR is fixing some issues I noticed here I also improved the codebase to be more uniformized with falco charts. |
According to falco rules, integrated rules in the helm values over yaml file. This allow user to easily customize rules. Signed-off-by: LeoFVO <[email protected]>
leofvo
force-pushed
the
refactor-falco-talon-chart
branch
from
500d1c2
to
e38c619
Compare
|
I'm currently in Norway for a talk, will review asap. Thanks a lot. |
What type of PR is this?
/kind cleanup
/kind feature
/kind chart-release
Any specific area of the project related to this PR?
/area falco-talon
What this PR does / why we need it:
I added support of name and namespace override for falco-talon as Falco is doing.
I added support for falco-talon custom rules. I found an issue that i wasn't able to custom talon rules due to a little mistake in the chart, after discussion with a maintainer, we have agreed to change this behavior to support it as Falco does.
Which issue(s) this PR fixes:
Fixes #falcosecurity/falco-talon#491 (comment)
Special notes for your reviewer:
This is my first contribution to Falco, don't hesitate to give me feedbacks if I can improve my proposals.
Checklist