Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Sign Helm Charts on release #427

Closed
wants to merge 1 commit into from

Conversation

e-minguez
Copy link
Contributor

@e-minguez e-minguez commented Nov 21, 2022

What type of PR is this?
/kind feature

Any specific area of the project related to this PR?
/area falco-chart

What this PR does / why we need it:
Currently, Helm Charts are not signed. It is an easy process that can be automated.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
I don't have enough permissions to test it. A GPG key needs to be created, stored in GitHub secrets, etc.
The official doc has more information https://helm.sh/docs/topics/provenance/ as well as this blog post I've found (it is for GH Actions but I guess it can be used as inspiration) https://colinwilson.uk/2022/01/27/how-to-sign-helm-charts-using-chart-releaser-action/
Also, this was originally posted in the falco slack channel -> https://kubernetes.slack.com/archives/CMWH3EH32/p1669040410546079

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana poiana added kind/feature New feature or request dco-signoff: no labels Nov 21, 2022
@poiana
Copy link
Contributor

poiana commented Nov 21, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: e-minguez
Once this PR has been reviewed and has the lgtm label, please assign cpanato for approval by writing /assign @cpanato in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Eduardo Minguez <[email protected]>
@leogr
Copy link
Member

leogr commented Nov 23, 2022

cc @cpanato @alacuku

@cpanato
Copy link
Member

cpanato commented Nov 23, 2022

do we have those secrets setup?

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leogr note for future, we should move this to github actions :)

@leogr
Copy link
Member

leogr commented Nov 23, 2022

do we have those secrets setup?

We only have GPG_KEY within a circleci context named falco. It's base64 encoded IIRC.
You can find some examples of its usage here 👇
https://github.com/falcosecurity/falco/blob/master/.circleci/config.yml#L282

@leogr
Copy link
Member

leogr commented Nov 23, 2022

@leogr note for future, we should move this to github actions :)

Totally agree. I believe it's time to make a plan 😃

@Issif
Copy link
Member

Issif commented Jan 23, 2023

FYI we started a WG has been created to address the supply chain security subjects

@leogr
Copy link
Member

leogr commented Jan 24, 2023

FYI we started a WG has been created to address the supply chain security subjects

Furthermore, we now agreed to deprecate CircleCI in favor of, so this PR should be reworked. @cpanato could you help?
cc @LucaGuerra (for secrets management)

@poiana
Copy link
Contributor

poiana commented Apr 24, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member

leogr commented Apr 27, 2023

/remove-lifecycle stale

@cpanato @LucaGuerra
Any progress on this?

@cpanato
Copy link
Member

cpanato commented Apr 27, 2023

i will revisit this, totally missed :(

@cpanato
Copy link
Member

cpanato commented Jun 7, 2023

ok, the idea is to move this to GH actions, correct @leogr , i can work on that but will require us to close this for now, is that okay?

@poiana
Copy link
Contributor

poiana commented Sep 5, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@cpanato
Copy link
Member

cpanato commented Sep 5, 2023

need a bit of time here :)

@cpanato
Copy link
Member

cpanato commented Sep 27, 2023

@leogr @LucaGuerra what is the idea here? we move the job to github actions? I dont remember the context anymore :(

but if that is the idea we will close this PR, if that is okay
waiting a confirmation to start the implementation

@leogr
Copy link
Member

leogr commented Sep 27, 2023

Hey @cpanato

Our general idea is to remove CircleCI in favor of GitHub Actions. Most of the repos across the org have already migrated. Notably, this repository is missing.

So I'm open to any plan that allows us to achieve the above goal in this repo too.

@cpanato
Copy link
Member

cpanato commented Sep 27, 2023

Hey @cpanato

Our general idea is to remove CircleCI in favor of GitHub Actions. Most of the repos across the org have already migrated. Notably, this repository is missing.

So I'm open to any plan that allows us to achieve the above goal in this repo too.

ok, let me work on the transition :)

@cpanato
Copy link
Member

cpanato commented Oct 19, 2023

we can close this in favor of #554

/close

@poiana
Copy link
Contributor

poiana commented Oct 19, 2023

@cpanato: Closed this PR.

In response to this:

we can close this in favor of #554

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants