-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Sign Helm Charts on release #427
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: e-minguez The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Eduardo Minguez <[email protected]>
do we have those secrets setup? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leogr note for future, we should move this to github actions :)
We only have |
Totally agree. I believe it's time to make a plan 😃 |
FYI we started a WG has been created to address the supply chain security subjects |
Furthermore, we now agreed to deprecate CircleCI in favor of, so this PR should be reworked. @cpanato could you help? |
Issues go stale after 90d of inactivity. Mark the issue as fresh with Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle stale |
/remove-lifecycle stale @cpanato @LucaGuerra |
i will revisit this, totally missed :( |
ok, the idea is to move this to GH actions, correct @leogr , i can work on that but will require us to close this for now, is that okay? |
Issues go stale after 90d of inactivity. Mark the issue as fresh with Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle stale |
need a bit of time here :) |
@leogr @LucaGuerra what is the idea here? we move the job to github actions? I dont remember the context anymore :( but if that is the idea we will close this PR, if that is okay |
Hey @cpanato Our general idea is to remove CircleCI in favor of GitHub Actions. Most of the repos across the org have already migrated. Notably, this repository is missing. So I'm open to any plan that allows us to achieve the above goal in this repo too. |
ok, let me work on the transition :) |
we can close this in favor of #554 /close |
@cpanato: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area falco-chart
What this PR does / why we need it:
Currently, Helm Charts are not signed. It is an easy process that can be automated.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
I don't have enough permissions to test it. A GPG key needs to be created, stored in GitHub secrets, etc.
The official doc has more information https://helm.sh/docs/topics/provenance/ as well as this blog post I've found (it is for GH Actions but I guess it can be used as inspiration) https://colinwilson.uk/2022/01/27/how-to-sign-helm-charts-using-chart-releaser-action/
Also, this was originally posted in the falco slack channel -> https://kubernetes.slack.com/archives/CMWH3EH32/p1669040410546079
Checklist