feat(static): implement Last-Modified header for static route

[Cycloctane]

Summary of Changes

• Render Last-Modified header for static file responses.
• Check request If-Modified-Since header and return 304 if date in this header is not earlier than mtime.
• Return 403 Forbidden for PermissionError when serving static.

Related Issues

Fixes #2244

Pull Request Checklist

• Applied changes to both WSGI and ASGI code paths and interfaces (where applicable).
• Added tests for changed code.
• Prefixed code comments with GitHub nick and an appropriate prefix.
• Coding style is consistent with the rest of the framework.
• Updated documentation for changed code.
  • Added docstrings for any new classes, functions, or modules.
  • Updated docstrings for any modifications to existing code.
  • Updated both WSGI and ASGI docs (where applicable).
  • Added references to new classes, functions, or modules to the relevant RST file under docs/.
  • Updated all relevant supporting documentation files under docs/.
  • A copyright notice is included at the top of any new modules (using your own name or the name of your organization).
  • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
• Changes (and possible deprecations) have towncrier news fragments under docs/_newsfragments/, with the file name format {issue_number}.{fragment_type}.rst. (Run towncrier --draft to ensure it renders correctly.)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ead6535) to head (6b7dd21).

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #2426   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         7728      7743   +15     
  Branches      1071      1071           
=========================================
+ Hits          7728      7743   +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[CaselIT]

nice improvement.

Some lines are not covered by tests, if you could add tests for them it would be great

[CaselIT]

let's set fh to None above the try then in the except do if fn is not None: fh.close() since in theory the io error could happen in os.fstat

[Cycloctane]

let's set fh to None above the try then in the except do if fn is not None: fh.close() since in theory the io error could happen in os.fstat

I tried using os.stat(file_path) instead to avoid handling fh outside _open_range(). This approach can also avoid unneccesary io.open when returning 304.

[vytas7]

Nice going overall so far 👍

I don't like this specific change though, please revert it if possible. We do want to stat() an open fd instead of path, as this prevents a number of race conditions, for instance, if the file in question is deleted between stat() and open(), etc.