-
-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(static): implement Last-Modified header for static route #2426
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2426 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 7729 7748 +19
Branches 1071 1073 +2
=========================================
+ Hits 7729 7748 +19 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice improvement.
Some lines are not covered by tests, if you could add tests for them it would be great
b1c90b4
to
cf105d5
Compare
Summary of Changes
Last-Modified
header for static file responses.If-Modified-Since
header and return 304 if date in this header is not earlier than mtime.Related Issues
Fixes #2244
Pull Request Checklist
docs/
.docs/
.versionadded
,versionchanged
, ordeprecated
directives.docs/_newsfragments/
, with the file name format{issue_number}.{fragment_type}.rst
. (Runtowncrier --draft
to ensure it renders correctly.)