Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix examples which return string/number #3348

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

matthewmayer
Copy link
Contributor

Partial manual fix for #3335 for clarifying the return type of examples

  • unquoted strings
  • incorrectly quoted numbers
  • doubled up examples

@matthewmayer matthewmayer requested a review from a team as a code owner December 28, 2024 18:19
@matthewmayer matthewmayer self-assigned this Dec 28, 2024
@matthewmayer matthewmayer added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Dec 28, 2024
Copy link

netlify bot commented Dec 28, 2024

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 50c21e0
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/677041476cfcc600080bf843
😎 Deploy Preview https://deploy-preview-3348.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (e6d27a3) to head (50c21e0).
Report is 4 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3348   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2811     2811           
  Lines      217017   217017           
  Branches      941      939    -2     
=======================================
  Hits       216966   216966           
  Misses         51       51           
Files with missing lines Coverage Δ
src/modules/color/index.ts 100.00% <ø> (ø)
src/modules/commerce/index.ts 97.71% <ø> (ø)
src/modules/date/index.ts 100.00% <ø> (ø)
src/modules/finance/index.ts 100.00% <ø> (ø)
src/modules/internet/index.ts 100.00% <ø> (ø)

@ST-DDT ST-DDT added this to the vAnytime milestone Dec 28, 2024
@ST-DDT ST-DDT requested review from a team December 28, 2024 18:54
@ST-DDT
Copy link
Member

ST-DDT commented Dec 29, 2024

I'll merge this early so that it doesn't conflict with the example formatting PR and so I have the latest improvements available.

@ST-DDT ST-DDT added this pull request to the merge queue Dec 29, 2024
Merged via the queue into faker-js:next with commit 637f81b Dec 29, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants