CHANGE: clean warning by creating cucumber_opts with %w[] instead of ''

- Declaring cucumber_opts with a string results in warnings when testing. Change that.
- Also lock minitest version to < 5.19.0 due to change in name of constant we rely on.

CHANGELOG.md

@@ -1,5 +1,7 @@
 # main [(unreleased)](https://github.com/whitesmith/rubycritic/compare/v4.8.1...main)
 
+* [CHANGE] Fix test warning related to `cucumber_opts` declaration (by [@faisal][])
+
 # v4.8.1 / 2023-05-17 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.8.0...v4.8.1)
 
 * [CHANGE] Update runtime dependencies to current versions of analysis gems (by [@faisal][])

Rakefile

@@ -14,7 +14,7 @@ Rake::TestTask.new do |task|
 end
 
 Cucumber::Rake::Task.new(:features) do |t|
-  t.cucumber_opts = 'features --format progress --color'
+  t.cucumber_opts = %w[features --format progress --color]
 end
 
 RuboCop::RakeTask.new

rubycritic.gemspec

@@ -52,7 +52,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'diff-lcs', '~> 1.3'
   spec.add_development_dependency 'fakefs', '~> 2.4.0'
   spec.add_development_dependency 'mdl', '~> 0.12.0'
-  spec.add_development_dependency 'minitest', '>= 5.3.0'
+  spec.add_development_dependency 'minitest', '>= 5.3.0', '< 5.19.0'
   spec.add_development_dependency 'minitest-around', '~> 0.5.0', '>= 0.4.0'
   spec.add_development_dependency 'mocha', '~> 2.0.2'
   spec.add_development_dependency 'rake', '~> 13.0.6', '>= 11.0.0'