-
-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated search assertions on some search tests / throttle tests (mocks and assertions) #649
Merged
Merged
Changes from 19 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
6bda416
Fixed code and unit tests
jbigman ccb3bb4
Bump semver from 6.3.0 to 6.3.1 and word-wrap from 1.2.3 to 1.2.4
jbigman afca862
String optimisation
jbigman 32c4b00
Use https://yesno.wtf/api for throttle tests
jbigman 3c9ba74
Set timeout to 18000ms: (3 times 5000ms + margin)
jbigman e6467c4
Set timeout to 30000ms: because we can't ensure called rest services…
jbigman e49ac11
Rerun checks
jbigman f09e537
Create main.yml
jbigman 505b4ef
Added logs to understand why check fails
jbigman 4cdf2b3
Added logs to understand why check fails
jbigman 9f098cc
Removed logs
jbigman 378a71f
Updated expected result for more reliable ones
jbigman 74cd435
39aaa8a9(Node version 12.x and 14.x are not supported anymore: https:…
jbigman b7dfebd
Updated should return apps from suggested search in european country …
jbigman 86395bf
Updated assertions "search with german language"
jbigman 2b40f86
Merge branch 'facundoolano:main' into main
jbigman 93ce5df
Fixed throttle tests (add mocks and updated expected results)
jbigman c336f83
Fixed eslint eol-last
jbigman 55d435f
Fixed gmail search assertions
jbigman 3364f8a
Moved sinon in dev dependencies, updated throttle tests with a 1000ms…
jbigman 73d3732
Fixed eslint
jbigman f16c23a
Moved sinon in dev dependencies, updated throttle tests with a 1000ms…
jbigman d944ed0
Updated throttle to 2000ms interval and assertions checks results +/-…
jbigman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be a dev dependency, since is it's only for tests