don't commit silently in helper method

facundoolano · Jan 3, 2024 · 6f2f233 · 6f2f233
1 parent d373d18
commit 6f2f233
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 1 deletion.
diff --git a/feedi/models.py b/feedi/models.py
@@ -548,7 +548,6 @@ def fetch_content(self):
         if self.content_url and not self.content_full:
             try:
                 self.content_full = scraping.extract(self.content_url)['content']
-                db.session.commit()
             except Exception:
                 pass
 

diff --git a/feedi/routes.py b/feedi/routes.py
@@ -440,6 +440,7 @@ def entry_view(id):
         # if full browser load or explicit content request, fetch the article synchronously
         entry.fetch_content()
         if entry.content_full:
+            db.session.commit()
             return flask.render_template("entry_content.html", entry=entry, content=entry.content_full)
 
         return redirect_response(entry.target_url)

diff --git a/feedi/tasks.py b/feedi/tasks.py
@@ -100,6 +100,7 @@ def content_prefetch():
         for entry in db.session.scalars(query):
             app.logger.debug('Prefetching %s', entry.content_url)
             entry.fetch_content()
+            db.session.commit()
 
 
 @feed_cli.command('purge')