Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rule to make sure that raw filter is justified by a comment #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

simonbaese
Copy link
Member

No description provided.

// NOTE: We expect exactly 17 violations in the fail scenario.
// In case we add more, don't forget to update violation count.
[$this->getFailScenarios(), 17],
[$this->getPassScenarios(), 0],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonbaese ,

Do we have a bug due to this aggregation? E.g. false postive and false negative combination from different scenarios that nullify each other when aggregated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give an example?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so because the lexer goes through the file token by token.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking about a scenario where a false positive is reported by the "with" rule and a false negative reported by "raw" rule which would cancel the aggregated count of each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants