Introduce environment variables to skip dialogs to automate PlotJuggler usage #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er usage Introduce the environment variables: PLOTJUGGLER_ACCEPT_PREVIOUSLY_USED_STREAMING_PLUGIN=1 to skip the dialog 'Start the previously used streaming plugin?' PLOTJUGGLER_CHOOSE_EMPTY_PLACEHOLDERS_ON_MISSING_TIMESERIES=1 to skip the dialog 'One or more timeseries in the layout haven't been loaded yet, What do you want to do?' Note that there is a sibling commit in plotjuggler-ros-plugins to skip the ROS topic selection dialog. This is a workaround for facontidavide#201 (passing commandline flags would require a lot of changes)
|
wouldn't be easier to add this in Preferences? |
|
also, Windows CI is unhappy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, @facontidavide let me apologize for doing this PR as I am the first one to see it is an ugly workaround, however, the functionality I think is great to have so...
Introducing the environment variables:
PLOTJUGGLER_ACCEPT_PREVIOUSLY_USED_STREAMING_PLUGIN=1to skip the dialog 'Start the previously used streaming plugin?'PLOTJUGGLER_CHOOSE_EMPTY_PLACEHOLDERS_ON_MISSING_TIMESERIES=1to skip the dialog 'One or more timeseries in the layout haven't been loaded yet, What do you want to do?'Note that there is a sibling PR in plotjuggler-ros-plugins (PlotJuggler/plotjuggler-ros-plugins#64) to skip the ROS topic selection dialog.
This is a workaround for #201 (passing commandline flags would require a lot of changes).
P.S.: I would have loved to pass it via commandline, but it required a lot of changes. And the plugin side would have needed many more to make it elegant. Maybe
PLOTJUGGLER_ACCEPT_PREVIOUSLY_USED_STREAMING_PLUGINcould be implemented as a commandline plugin. Which, by the way, I did not understand what--start_streamerdoes... I thought it would do that, but I couldn't make it do anything. My bad.P.S.2: I do not expect this to be merged due to the lack of elegance, specially being the main PlotJuggler repo. But maybe people will want it enough to build from source. (I may).