Use "React.Fragment" to render flushed components without "span" #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
createApiWithCss
now returnsJs
,Styles
andCss
React components usingReact.Fragment
to render their children without a wrapping<span>
createApiWithCss
snapshot changed according to the changes in the source fileBenefits
span
which shouldn't wrap<link>
or<script>
elementsConsequences
Side notes
I've thought about this change and introduced a small pull request to cover it. I am not very familiar with Jest and its snapshots system, so you better check if I changed the snapshots correctly.
By the way, not a very good idea to include whitespaces as a part of a snapshot. Some IDE remove trailing whitespaces automatically, which causes snapshots to fail. You may want to consider removing whitespaces.