Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction to the github actions to allow windows builds on CUDA other than 12.4 to build. #1210

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

Correction to the github actions to allow windows builds on CUDA other than 12.4 to build. #1210

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6555558
Correction to windows builds allow CUDA other than 12.4 to build. It …
kimnzl Feb 3, 2025
26d11b0
Allow uploading 12.6 wheels
kimnzl Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
for torch_version in ['2.6.0']:
# CUDA builds
for python, cuda_short_version in PY_CU:
if cuda_short_version != "124" and "windows" in os:
if fromJSON(cuda_short_version) < fromJSON("124") and "windows" in os:
print("Windows builder no longer compatible with cu<124")
continue
include.append(dict(
Expand Down Expand Up @@ -98,7 +98,7 @@ jobs:
uses: ./.github/workflows/wheels_upload_pip.yml
with:
twine_username: __token__
filter: "*torch2.6.0+cu124*"
filter: "*torch2.6.0+cu12*"
execute: ${{ github.repository == 'facebookresearch/xformers' && github.event_name != 'pull_request' }}
secrets:
twine_password: ${{ secrets.PYPI_TOKEN }}
Expand Down