Speedup patch embedding by moving coord creation on device #595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While experimenting with image segmentation and using the
prun
function onpredictor.set_image
, I discovered a significant performance issue in theget_rel_pos
function.The problem arises from the lack of device assignment for the tensor containing relative positions, causing unnecessary data transfers when using accelerators like GPUs.
The solution is rather simple: create the coordinate tensor on the same device as the underlying data.
In my specific case (vit-b, P100 GPU, 128x128 image size), this change reduced the
get_rel_pos
execution time from 197ms to 3ms, cutting down thepredictor.set_image
runtime from 220ms to 20ms.Given that there's no reason to keep the coordinate tensor creation outside the device, I suggest incorporating this change into the official release for the benefit of all users.