Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Flash Attention kernel not found issue. #322

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lzbgt
Copy link

@lzbgt lzbgt commented Sep 23, 2024

since sdk_kernel in backends.cuda is deprecated by torch.nn.attention.sdpa_kernel.

@facebook-github-bot
Copy link

Hi @lzbgt!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@catwell
Copy link

catwell commented Nov 20, 2024

This does not fix the FlashAttention not found issue, it just silents the log because it will fallback to the next kernel.

@lzbgt
Copy link
Author

lzbgt commented Dec 6, 2024

"flash attention not found" should not be corrected by this.
user should check flash attention installed/setup correctly

dcnieho added a commit to dcnieho/segment-anything-2 that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants