Allow user defined warm-up iterations #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shengfukevin
requested review from
kingchc,
louisfeng,
sunghlin,
shengbao-zheng and
briancoutinho
as code owners
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66801912 |
shengfukevin
added a commit
to shengfukevin/param
that referenced
this pull request
Dec 5, 2024
Summary: Allow user to specify the number of warmup iteration runs. Also print out the wall clock time for each iteration and the average wall clock time for the whole run. Differential Revision: D66801912
shengfukevin
force-pushed
the
export-D66801912
branch
from
208634c to
e5fd052
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66801912 |
shengfukevin
added a commit
to shengfukevin/param
that referenced
this pull request
Dec 5, 2024
Summary: Allow user to specify the number of warmup iteration runs. Also print out the wall clock time for each iteration and the average wall clock time for the whole run. Differential Revision: D66801912
shengfukevin
force-pushed
the
export-D66801912
branch
from
e5fd052 to
d1a97b9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66801912 |
shengfukevin
added a commit
to shengfukevin/param
that referenced
this pull request
Dec 5, 2024
Summary: Allow user to specify the number of warmup iteration runs. Also print out the wall clock time for each iteration and the average wall clock time for the whole run. Differential Revision: D66801912
shengfukevin
force-pushed
the
export-D66801912
branch
from
d1a97b9 to
363580e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66801912 |
shengfukevin
added a commit
to shengfukevin/param
that referenced
this pull request
Dec 5, 2024
Summary: Allow user to specify the number of warmup iteration runs. Also print out the wall clock time for each iteration and the average wall clock time for the whole run. Differential Revision: D66801912
shengfukevin
force-pushed
the
export-D66801912
branch
from
363580e to
0990539
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66801912 |
shengfukevin
force-pushed
the
export-D66801912
branch
from
0990539 to
2bef03b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66801912 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D66801912 |
shengfukevin
added a commit
to shengfukevin/param
that referenced
this pull request
Dec 10, 2024
… iterations (facebookresearch#189) Summary: Meta production is on Python 3.10. PARAM lint is still on 3.8. I saw Lint reported some issues related to type hint syntax. To fix it, I upgrade python to 3.10. ALso changed the option to allow user to specify the number of warmup iteration runs. Also print out the wall clock time for each iteration and the average wall clock time for the whole run. Reviewed By: kingchc Differential Revision: D66801912
shengfukevin
force-pushed
the
export-D66801912
branch
from
2bef03b to
a29fcd0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66801912 |
shengfukevin
added a commit
to shengfukevin/param
that referenced
this pull request
Dec 10, 2024
… iterations (facebookresearch#189) Summary: Meta production is on Python 3.10. PARAM lint is still on 3.8. I saw Lint reported some issues related to type hint syntax. To fix it, I upgrade python to 3.10. ALso changed the option to allow user to specify the number of warmup iteration runs. Also print out the wall clock time for each iteration and the average wall clock time for the whole run. Reviewed By: kingchc Differential Revision: D66801912
shengfukevin
force-pushed
the
export-D66801912
branch
from
a29fcd0 to
22646a7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66801912 |
shengfukevin
added a commit
to shengfukevin/param
that referenced
this pull request
Dec 10, 2024
… iterations (facebookresearch#189) Summary: Meta production is on Python 3.10. PARAM lint is still on 3.8. I saw Lint reported some issues related to type hint syntax. To fix it, I upgrade python to 3.10. ALso changed the option to allow user to specify the number of warmup iteration runs. Also print out the wall clock time for each iteration and the average wall clock time for the whole run. Reviewed By: kingchc Differential Revision: D66801912
shengfukevin
force-pushed
the
export-D66801912
branch
from
d56f285 to
9bacbed
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66801912 |
shengfukevin
added a commit
to shengfukevin/param
that referenced
this pull request
Dec 10, 2024
… iterations (facebookresearch#189) Summary: Meta production is on Python 3.10. PARAM lint is still on 3.8. I saw Lint reported some issues related to type hint syntax. To fix it, I upgrade python to 3.10. ALso changed the option to allow user to specify the number of warmup iteration runs. Also print out the wall clock time for each iteration and the average wall clock time for the whole run. Reviewed By: kingchc Differential Revision: D66801912
shengfukevin
force-pushed
the
export-D66801912
branch
from
9bacbed to
9796407
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66801912 |
shengfukevin
added a commit
to shengfukevin/param
that referenced
this pull request
Dec 10, 2024
… iterations (facebookresearch#189) Summary: Meta production is on Python 3.10. PARAM lint is still on 3.8. I saw Lint reported some issues related to type hint syntax. To fix it, I upgrade python to 3.10. ALso changed the option to allow user to specify the number of warmup iteration runs. Also print out the wall clock time for each iteration and the average wall clock time for the whole run. Reviewed By: kingchc Differential Revision: D66801912
shengfukevin
force-pushed
the
export-D66801912
branch
from
9796407 to
f25002b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66801912 |
shengfukevin
added a commit
to shengfukevin/param
that referenced
this pull request
Dec 10, 2024
… iterations (facebookresearch#189) Summary: Meta production is on Python 3.10. PARAM lint is still on 3.8. I saw Lint reported some issues related to type hint syntax. To fix it, I upgrade python to 3.10. ALso changed the option to allow user to specify the number of warmup iteration runs. Also print out the wall clock time for each iteration and the average wall clock time for the whole run. Reviewed By: kingchc Differential Revision: D66801912
shengfukevin
force-pushed
the
export-D66801912
branch
from
f25002b to
4768f64
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66801912 |
shengfukevin
added a commit
to shengfukevin/param
that referenced
this pull request
Dec 10, 2024
… iterations (facebookresearch#189) Summary: Meta production is on Python 3.10. PARAM lint is still on 3.8. I saw Lint reported some issues related to type hint syntax. To fix it, I upgrade python to 3.10. ALso changed the option to allow user to specify the number of warmup iteration runs. Also print out the wall clock time for each iteration and the average wall clock time for the whole run. Reviewed By: kingchc Differential Revision: D66801912
shengfukevin
force-pushed
the
export-D66801912
branch
from
4768f64 to
4b5b050
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66801912 |
shengfukevin
added a commit
to shengfukevin/param
that referenced
this pull request
Dec 10, 2024
… iterations (facebookresearch#189) Summary: Meta production is on Python 3.10. PARAM lint is still on 3.8. I saw Lint reported some issues related to type hint syntax. To fix it, I upgrade python to 3.10. ALso changed the option to allow user to specify the number of warmup iteration runs. Also print out the wall clock time for each iteration and the average wall clock time for the whole run. Reviewed By: kingchc Differential Revision: D66801912
shengfukevin
force-pushed
the
export-D66801912
branch
from
4b5b050 to
7665e0f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66801912 |
shengfukevin
added a commit
to shengfukevin/param
that referenced
this pull request
Dec 10, 2024
… iterations (facebookresearch#189) Summary: Meta production is on Python 3.10. PARAM lint is still on 3.8. I saw Lint reported some issues related to type hint syntax. To fix it, I upgrade python to 3.10. ALso changed the option to allow user to specify the number of warmup iteration runs. Also print out the wall clock time for each iteration and the average wall clock time for the whole run. Reviewed By: kingchc Differential Revision: D66801912
shengfukevin
force-pushed
the
export-D66801912
branch
from
7665e0f to
06f95dd
Compare
shengfukevin
added a commit
to shengfukevin/param
that referenced
this pull request
Dec 10, 2024
… iterations (facebookresearch#189) Summary: Meta production is on Python 3.10. PARAM lint is still on 3.8. I saw Lint reported some issues related to type hint syntax. To fix it, I upgrade python to 3.10. ALso changed the option to allow user to specify the number of warmup iteration runs. Also print out the wall clock time for each iteration and the average wall clock time for the whole run. Reviewed By: kingchc Differential Revision: D66801912
shengfukevin
force-pushed
the
export-D66801912
branch
from
06f95dd to
90ca93b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66801912 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D66801912 |
… iterations (facebookresearch#189) Summary: Meta production is on Python 3.10. PARAM lint is still on 3.8. I saw Lint reported some issues related to type hint syntax. To fix it, I upgrade python to 3.10. ALso changed the option to allow user to specify the number of warmup iteration runs. Also print out the wall clock time for each iteration and the average wall clock time for the whole run. Reviewed By: kingchc Differential Revision: D66801912
shengfukevin
force-pushed
the
export-D66801912
branch
from
90ca93b to
2cf4284
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66801912 |
|
This pull request has been merged in b691d61. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Allow user to specify the number of warmup iteration runs. Also print out the wall clock time for each iteration and the average wall clock time for the whole run.
Differential Revision: D66801912