Restructure et_relay subpackage (#129) #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanrise
requested review from
kingchc,
louisfeng,
sunghlin,
wfu-fb,
shengbao-zheng and
briancoutinho
as code owners
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59178710 |
|
This work was originally authored in #124. But this change requires simultaneous changes to internal TARGETS (build) file, so I had to abandon the previous PRs, make my changes on top of them inside Meta and re-export this PR here. (cc: @TaekyungHeo, @amaslenn as the original authors) |
|
This pull request was exported from Phabricator. Differential Revision: D59178710 |
sanrise
pushed a commit
to sanrise/param
that referenced
this pull request
Jul 15, 2024
Summary: Pull Request resolved: facebookresearch#133 1. Make `et_replay` structure easier to refactor: added an entry point to export public symbols, used it in train code. 2. Enabled tests run as part of GHA CI. Reviewed at facebookresearch#124 Pull Request resolved: facebookresearch#129 Test Plan: CI ## Additional Notes -- Differential Revision: D59178710 Pulled By: sanrise
sanrise
force-pushed
the
export-D59178710
branch
from
0fdac0e to
6e6eb8f
Compare
sanrise
added a commit
to sanrise/HolisticTraceAnalysis
that referenced
this pull request
Jul 15, 2024
Summary: For changes originating in facebookresearch/param#133. ET replay package modules are getting flatter and simpler to import. Updating references in HTA to be the same. Differential Revision: D59748145
|
This pull request was exported from Phabricator. Differential Revision: D59178710 |
sanrise
pushed a commit
to sanrise/param
that referenced
this pull request
Jul 15, 2024
Summary: Pull Request resolved: facebookresearch#133 1. Make `et_replay` structure easier to refactor: added an entry point to export public symbols, used it in train code. 2. Enabled tests run as part of GHA CI. Reviewed at facebookresearch#124 Pull Request resolved: facebookresearch#129 Test Plan: CI ## Additional Notes -- Differential Revision: D59178710 Pulled By: sanrise
sanrise
force-pushed
the
export-D59178710
branch
from
6e6eb8f to
4a33d24
Compare
Summary: Pull Request resolved: facebookresearch#133 1. Make `et_replay` structure easier to refactor: added an entry point to export public symbols, used it in train code. 2. Enabled tests run as part of GHA CI. Reviewed at facebookresearch#124 Pull Request resolved: facebookresearch#129 Test Plan: CI ## Additional Notes -- Reviewed By: shengfukevin Differential Revision: D59178710 Pulled By: sanrise
sanrise
added a commit
to sanrise/HolisticTraceAnalysis
that referenced
this pull request
Jul 16, 2024
Summary: Pull Request resolved: facebookresearch#163 For changes originating in facebookresearch/param#133. ET replay package modules are getting flatter and simpler to import. Updating references in HTA to be the same. Reviewed By: shengfukevin Differential Revision: D59748145
|
This pull request was exported from Phabricator. Differential Revision: D59178710 |
sanrise
force-pushed
the
export-D59178710
branch
from
4a33d24 to
225db8d
Compare
sanrise
added a commit
to sanrise/HolisticTraceAnalysis
that referenced
this pull request
Jul 16, 2024
Summary: Pull Request resolved: facebookresearch#163 For changes originating in facebookresearch/param#133. ET replay package modules are getting flatter and simpler to import. Updating references in HTA to be the same. Reviewed By: shengfukevin Differential Revision: D59748145
facebook-github-bot
pushed a commit
to facebookresearch/HolisticTraceAnalysis
that referenced
this pull request
Jul 16, 2024
Summary: Pull Request resolved: #163 For changes originating in facebookresearch/param#133. ET replay package modules are getting flatter and simpler to import. Updating references in HTA to be the same. Reviewed By: shengfukevin Differential Revision: D59748145 fbshipit-source-id: bc203df772ae416b70d44b981f0298db10c2af16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
et_replaystructure easier to refactor: added an entry point to export public symbols, used it in train code.Reviewed at #124
Test Plan:
CI
Additional Notes
--
Differential Revision: D59178710
Pulled By: sanrise