-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support tensor stride #126
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was exported from Phabricator. Differential Revision: D58900476 |
shengfukevin
added a commit
to shengfukevin/pytorch
that referenced
this pull request
Jun 22, 2024
Summary: X-link: facebookresearch/param#126 Support tensor stride for execution trace. Test Plan: buck2 test mode/opt caffe2/test:test_profiler_cuda profiler.test_execution_trace.TestExecutionTrace Differential Revision: D58900476
This pull request was exported from Phabricator. Differential Revision: D58900476 |
shengfukevin
added a commit
to shengfukevin/param
that referenced
this pull request
Jul 8, 2024
Summary: X-link: pytorch/pytorch#129297 Pull Request resolved: facebookresearch#126 Support tensor stride for execution trace. Reviewed By: sanrise Differential Revision: D58900476
0bd05b0
to
e3da5f3
Compare
Summary: X-link: pytorch/pytorch#129297 Pull Request resolved: facebookresearch#126 Support tensor stride for execution trace. Reviewed By: sanrise Differential Revision: D58900476
This pull request was exported from Phabricator. Differential Revision: D58900476 |
e3da5f3
to
d5548be
Compare
shengfukevin
added a commit
to shengfukevin/pytorch
that referenced
this pull request
Jul 8, 2024
Summary: Pull Request resolved: pytorch#129297 X-link: facebookresearch/param#126 Support tensor stride for execution trace. Test Plan: buck2 test mode/opt caffe2/test:test_profiler_cuda profiler.test_execution_trace.TestExecutionTrace Reviewed By: sanrise Differential Revision: D58900476
shengfukevin
added a commit
to shengfukevin/pytorch
that referenced
this pull request
Jul 8, 2024
Summary: Pull Request resolved: pytorch#129297 X-link: facebookresearch/param#126 Support tensor stride for execution trace. Test Plan: buck2 test mode/opt caffe2/test:test_profiler_cuda profiler.test_execution_trace.TestExecutionTrace Reviewed By: sanrise Differential Revision: D58900476
shengfukevin
added a commit
to shengfukevin/pytorch
that referenced
this pull request
Jul 8, 2024
Summary: Pull Request resolved: pytorch#129297 X-link: facebookresearch/param#126 Support tensor stride for execution trace. Test Plan: buck2 test mode/opt caffe2/test:test_profiler_cuda profiler.test_execution_trace.TestExecutionTrace Reviewed By: sanrise Differential Revision: D58900476
sanrise
approved these changes
Jul 8, 2024
lgtm, some linter issues have popped up that may need fixing |
This pull request has been merged in 9391736. |
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jul 9, 2024
Summary: X-link: facebookresearch/param#126 Support tensor stride for execution trace. Test Plan: buck2 test mode/opt caffe2/test:test_profiler_cuda profiler.test_execution_trace.TestExecutionTrace Differential Revision: D58900476 Pull Request resolved: #129297 Approved by: https://github.com/sanrise, https://github.com/izaitsevfb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Support tensor stride for execution trace.
Differential Revision: D58900476