Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tensor stride #126

Closed

Conversation

shengfukevin
Copy link
Contributor

Summary: Support tensor stride for execution trace.

Differential Revision: D58900476

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 22, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58900476

shengfukevin added a commit to shengfukevin/pytorch that referenced this pull request Jun 22, 2024
Summary:
X-link: facebookresearch/param#126

Support tensor stride for execution trace.

Test Plan: buck2 test mode/opt caffe2/test:test_profiler_cuda profiler.test_execution_trace.TestExecutionTrace

Differential Revision: D58900476
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58900476

shengfukevin added a commit to shengfukevin/param that referenced this pull request Jul 8, 2024
Summary:
X-link: pytorch/pytorch#129297

Pull Request resolved: facebookresearch#126

Support tensor stride for execution trace.

Reviewed By: sanrise

Differential Revision: D58900476
@shengfukevin shengfukevin requested a review from sanrise July 8, 2024 17:14
Summary:
X-link: pytorch/pytorch#129297

Pull Request resolved: facebookresearch#126

Support tensor stride for execution trace.

Reviewed By: sanrise

Differential Revision: D58900476
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58900476

shengfukevin added a commit to shengfukevin/pytorch that referenced this pull request Jul 8, 2024
Summary:
Pull Request resolved: pytorch#129297

X-link: facebookresearch/param#126

Support tensor stride for execution trace.

Test Plan: buck2 test mode/opt caffe2/test:test_profiler_cuda profiler.test_execution_trace.TestExecutionTrace

Reviewed By: sanrise

Differential Revision: D58900476
shengfukevin added a commit to shengfukevin/pytorch that referenced this pull request Jul 8, 2024
Summary:
Pull Request resolved: pytorch#129297

X-link: facebookresearch/param#126

Support tensor stride for execution trace.

Test Plan: buck2 test mode/opt caffe2/test:test_profiler_cuda profiler.test_execution_trace.TestExecutionTrace

Reviewed By: sanrise

Differential Revision: D58900476
shengfukevin added a commit to shengfukevin/pytorch that referenced this pull request Jul 8, 2024
Summary:
Pull Request resolved: pytorch#129297

X-link: facebookresearch/param#126

Support tensor stride for execution trace.

Test Plan: buck2 test mode/opt caffe2/test:test_profiler_cuda profiler.test_execution_trace.TestExecutionTrace

Reviewed By: sanrise

Differential Revision: D58900476
@sanrise
Copy link

sanrise commented Jul 8, 2024

lgtm, some linter issues have popped up that may need fixing

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 9391736.

pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request Jul 9, 2024
Summary:
X-link: facebookresearch/param#126

Support tensor stride for execution trace.

Test Plan: buck2 test mode/opt caffe2/test:test_profiler_cuda profiler.test_execution_trace.TestExecutionTrace

Differential Revision: D58900476

Pull Request resolved: #129297
Approved by: https://github.com/sanrise, https://github.com/izaitsevfb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants