Change et_replay test to a unit test #118
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shengfukevin
requested review from
kingchc,
louisfeng,
sunghlin,
wfu-fb,
shengbao-zheng and
briancoutinho
as code owners
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57590633 |
shengfukevin
added a commit
to shengfukevin/param
that referenced
this pull request
May 22, 2024
Summary: This DIFF is to change test_et_replay from a binary to a unit test, so when the dependent libraries change, the test will run automatically. Reviewed By: briancoutinho Differential Revision: D57590633
shengfukevin
force-pushed
the
export-D57590633
branch
from
8142f8f to
9111a33
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57590633 |
Summary: This DIFF is to change test_et_replay from a binary to a unit test, so when the dependent libraries change, the test will run automatically. Reviewed By: briancoutinho Differential Revision: D57590633
shengfukevin
force-pushed
the
export-D57590633
branch
from
9111a33 to
5e6a04d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57590633 |
|
This pull request has been merged in ee9071f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This DIFF is to change test_et_replay from a binary to a unit test, so when the dependent libraries change, the test will run automatically.
Reviewed By: briancoutinho
Differential Revision: D57590633