Start initial refactor of et replay #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briancoutinho
requested review from
kingchc,
louisfeng,
sunghlin,
wfu-fb and
shengbao-zheng
as code owners
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56960365 |
|
@briancoutinho do we create additional subdirectories for compute and comms? |
|
Ohh no, so this does depend on files in param/train/ we can keep using that
and at some later point refactor and rename them ( do the full param
refactor)
For comms if we want we can add our own files and implementation in
et_teplay/
For compute it should be fine to just use things as is.
…On Fri, May 3, 2024 at 6:20 PM srinivas212 ***@***.***> wrote:
@briancoutinho <https://github.com/briancoutinho> do we create additional
subdirectories for compute and comms?
—
Reply to this email directly, view it on GitHub
<#110 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABUZ7ZEX22VOXT2XGSJJVRLZAQZUZAVCNFSM6AAAAABHGJX4QOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJTHE2DAOJRGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
This pull request was exported from Phabricator. Differential Revision: D56960365 |
briancoutinho
added a commit
that referenced
this pull request
May 7, 2024
Summary: Pull Request resolved: #110 Add a new tree structure for et_replay to enable better encapsulation of this code. We keep comms and compute unchanged, only moving et_replay files. ``` [[email protected] ~/fbsource/fbcode/param_bench/et_replay (d4b11e786)]$ tree . . ├── lib │ ├── et_replay_utils.py │ ├── execution_trace.py │ └── utils.py ├── README.md ├── tests │ ├── inputs │ │ ├── 1.0.3-chakra.0.0.4 │ │ │ └── resnet_1gpu_et.json.gz │ │ ├── 1.1.0-chakra.0.0.4 │ │ │ └── resnet_2gpu_et.json.gz │ │ ├── dlrm_kineto.tar.gz │ │ ├── dlrm_pytorch_et.tar.gz │ │ ├── __init__.py │ │ ├── linear_et.json.gz │ │ ├── linear_kineto.json.gz │ │ ├── resnet_et.json.gz │ │ └── resnet_kineto.json.gz │ └── test_execution_trace.py └── tools ├── et_replay.py └── validate_trace.py ``` Differential Revision: D56960365
briancoutinho
force-pushed
the
export-D56960365
branch
from
5b0f878 to
721c137
Compare
briancoutinho
changed the title
Summary: Pull Request resolved: #110 Add a new tree structure for et_replay to enable better encapsulation of this code. We keep comms and compute unchanged, only moving et_replay files. ``` [[email protected] ~/fbsource/fbcode/param_bench/et_replay (d4b11e786)]$ tree . . ├── lib │ ├── et_replay_utils.py │ ├── execution_trace.py │ └── utils.py ├── README.md ├── tests │ ├── inputs │ │ ├── 1.0.3-chakra.0.0.4 │ │ │ └── resnet_1gpu_et.json.gz │ │ ├── 1.1.0-chakra.0.0.4 │ │ │ └── resnet_2gpu_et.json.gz │ │ ├── dlrm_kineto.tar.gz │ │ ├── dlrm_pytorch_et.tar.gz │ │ ├── __init__.py │ │ ├── linear_et.json.gz │ │ ├── linear_kineto.json.gz │ │ ├── resnet_et.json.gz │ │ └── resnet_kineto.json.gz │ └── test_execution_trace.py └── tools ├── et_replay.py └── validate_trace.py ``` Differential Revision: D56960365
|
This pull request was exported from Phabricator. Differential Revision: D56960365 |
briancoutinho
force-pushed
the
export-D56960365
branch
from
721c137 to
497533d
Compare
briancoutinho
added a commit
to briancoutinho/HolisticTraceAnalysis
that referenced
this pull request
May 7, 2024
Summary: X-link: facebookresearch/param#110 Add a new tree structure for et_replay to enable better encapsulation of this code. We keep comms and compute unchanged, only moving et_replay files. ``` [[email protected] ~/fbsource/fbcode/param_bench/et_replay (d4b11e786)]$ tree . . ├── lib │ ├── et_replay_utils.py │ ├── execution_trace.py │ └── utils.py ├── README.md ├── tests │ ├── inputs │ │ ├── 1.0.3-chakra.0.0.4 │ │ │ └── resnet_1gpu_et.json.gz │ │ ├── 1.1.0-chakra.0.0.4 │ │ │ └── resnet_2gpu_et.json.gz │ │ ├── dlrm_kineto.tar.gz │ │ ├── dlrm_pytorch_et.tar.gz │ │ ├── __init__.py │ │ ├── linear_et.json.gz │ │ ├── linear_kineto.json.gz │ │ ├── resnet_et.json.gz │ │ └── resnet_kineto.json.gz │ └── test_execution_trace.py └── tools ├── et_replay.py └── validate_trace.py ``` Differential Revision: D56960365
|
This pull request has been merged in 9b1946f. |
facebook-github-bot
pushed a commit
to facebookresearch/HolisticTraceAnalysis
that referenced
this pull request
May 7, 2024
Summary: Pull Request resolved: #131 X-link: facebookresearch/param#110 Add a new tree structure for et_replay to enable better encapsulation of this code. We keep comms and compute unchanged, only moving et_replay files. ``` [[email protected] ~/fbsource/fbcode/param_bench/et_replay (d4b11e786)]$ tree . . ├── lib │ ├── et_replay_utils.py │ ├── execution_trace.py │ └── utils.py ├── README.md ├── tests │ ├── inputs │ │ ├── 1.0.3-chakra.0.0.4 │ │ │ └── resnet_1gpu_et.json.gz │ │ ├── 1.1.0-chakra.0.0.4 │ │ │ └── resnet_2gpu_et.json.gz │ │ ├── dlrm_kineto.tar.gz │ │ ├── dlrm_pytorch_et.tar.gz │ │ ├── __init__.py │ │ ├── linear_et.json.gz │ │ ├── linear_kineto.json.gz │ │ ├── resnet_et.json.gz │ │ └── resnet_kineto.json.gz │ └── test_execution_trace.py └── tools ├── et_replay.py └── validate_trace.py ``` Reviewed By: shengfukevin Differential Revision: D56960365 fbshipit-source-id: d2ef172bc6c4629d78222357e616df9bddaec81e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new tree structure for et_replay to enable better encapsulation of this code. We keep comms and compute unchanged, only moving et_replay files.
Differential Revision: D56960365