Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in communication trace parsing #104

Closed
wants to merge 1 commit into from
Closed

Bugfix in communication trace parsing #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions train/comms/pt/commsTraceParser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,12 @@ def _parseExecutionTrace(
) # wait/barrier ops do not have an input tensor (len=7), shift index one over
newComm = commsArgs()
newComm.id = node.id

if type(node.inputs[3]) == str:
shift = 1
else:
shift = 0

newComm.comms = comms_utils.paramToCommName(
node.inputs[4 - shift].lower()
) # 5th value of inputs is colName
Expand Down
Loading